Github user Ritabrata-TW commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130595893
  
    --- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
    @@ -1215,9 +1210,13 @@ public TopicRouteData 
getTopicRouteInfoFromNameServer(final String topic, final
             assert response != null;
             switch (response.getCode()) {
                 case ResponseCode.TOPIC_NOT_EXIST: {
    -                if (!topic.equals(MixAll.DEFAULT_TOPIC))
    +                if (allowTopicNotExist && 
!topic.equals(MixAll.DEFAULT_TOPIC)) {
                         log.warn("get Topic [{}] RouteInfoFromNameServer is 
not exist value", topic);
    -                break;
    +                    break;
    +                } else {
    +                    // TODO LOG
    --- End diff --
    
    @shroman The TODO was already there. Not sure what to do about it right 
now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to