Github user Ritabrata-TW commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130596160
  
    --- Diff: 
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
    @@ -717,22 +718,28 @@ public long getEarliestMessageTime(String topic, int 
queueId) {
                 long minLogicOffset = logicQueue.getMinLogicOffset();
     
                 SelectMappedBufferResult result = 
logicQueue.getIndexBuffer(minLogicOffset / ConsumeQueue.CQ_STORE_UNIT_SIZE);
    -            if (result != null) {
    -                try {
    -                    final long phyOffset = 
result.getByteBuffer().getLong();
    -                    final int size = result.getByteBuffer().getInt();
    -                    long storeTime = 
this.getCommitLog().pickupStoreTimestamp(phyOffset, size);
    -                    return storeTime;
    -                } catch (Exception e) {
    -                } finally {
    -                    result.release();
    -                }
    -            }
    +            Long storeTime = getStoreTime(result);
    +            return storeTime;
    --- End diff --
    
    Yup. Made the change. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to