Github user qqeasonchen commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/139#discussion_r130866438
  
    --- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
 ---
    @@ -255,19 +255,17 @@ public void start() throws MQClientException {
         }
     
         private void startScheduledTask() {
    -        if (null == this.clientConfig.getNamesrvAddr()) {
    --- End diff --
    
    @Jaskey agree with you , and my question is if user does not specify an 
namesrv and its purpose is fetch from wsAddr , but client can not fetch 
namesrvs dymatically , see 
    
    // If not specified,looking address from name server 
    if (null == this.clientConfig.getNamesrvAddr()) { 
this.mQClientAPIImpl.fetchNameServerAddr(); }
     
    private void startScheduledTask() {
          if (null == this.clientConfig.getNamesrvAddr()) {.......}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to