Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/139#discussion_r131031474
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -255,19 +255,17 @@ public void start() throws MQClientException {
}
private void startScheduledTask() {
- if (null == this.clientConfig.getNamesrvAddr()) {
--- End diff --
@Jaskey yes, this (current) design is surely ok. But it makes sense to
discuss it in the dev mailing list, because everyone has a different idea what
the best one is.
For instance, I would change what you describe a little bit like this
```
1. when specified nameserver address, no need to fetch nameserver
address dynamically.
2. Only fetch nameserver address when the user-defined nameserver fails.
I don't think any inconsistencies should happen, because it's a
user's choice to enable dynamic fetching (We can implement such a switch to
enable/disable it).
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
