Hi, Edd, first of all many thanks for using Apache Roller!
http://www.eddgrant.com/blog/
I had no clue we had a Git mirror, but I would prefer keeping all change
requests via patch in JIRA anyway instead of maintaining two sources of
record for change requests, i.e., let's keep the GitHub read-only until
we retire SVN (we're a tiny project). The other project I'm aware of
that use Git mirrors (namely, CXF) still has bug reports/patches sent
via JIRA for others to review and comment on--AFAIK pull requests aren't
used.
Your changes seem to make sense (
http://stackoverflow.com/questions/115983/how-do-i-add-an-empty-directory-to-a-git-repository),
but I would need to place them in via SVN (again, fine with me). Rather
than create empty directories, it might be better to change the build so
those empty folders wouldn't be necessary, but I don't know if/when we
can get to that. The other change you have about the repository issue
seems to make sense.
Glen
On 01/31/2013 08:18 AM, Dave wrote:
As far as I know, that Github is just a read only mirror of Roller. I don't
have access to the "apache" Guthub account and cannot accept pull requests
from it. I'll look into this, but in the meantime you may want to submit a
traditional patch for your change.
- Dave
On Thu, Jan 31, 2013 at 3:55 AM, Edd Grant <[email protected]> wrote:
Hi all,
I submitted a pull request to Roller on GitHub 5 or so months ago. Haven't
received any feedback on it so was just wondering if anyone is watching
that account?
Pull request can be found here:
https://github.com/apache/roller/pull/3(very simple, just to do with
location of m2 repos so a fresh checkout
works for more users without modification)
If there's something wrong with the pull request just let me know and I'll
be happy to make any corrections, or if the project isn't interested in the
change then that's fine but would appreciate the confirmation either way.
Cheers,
Edd
--
Web: http://www.eddgrant.com
Email: [email protected]
Mobile: +44 (0) 7861 394 543
