Edd, sorry, I misunderstood your email, I thought you already had
supplied a patch, yes, please do so to JIRA:
https://issues.apache.org/jira/browse/ROL, also include the folder
changes so Roller is more GitHub friendly. Thankfully, I'm now having
more time for Roller.
I regret that we are on GitHub -- this team is too small to maintain
both SVN and GitHub, and I don't want others to fall into the
energy-wasting trap that you fell into (of making pull requests to a
read-only GitHub repo instead of using the JIRA process). But
apparently 13 others have already forked Roller on GitHub, so I'm not
sure we can get rid of it (indeed, it seems virtually every other Apache
project is on it anyway, we might not have a choice.)
Glen
On 02/26/2013 11:08 AM, Glen Mazza wrote:
Sorry Edd, I have very little time right now unfortunately for either
of my two dear open source projects, however, that will be nicely
changing 31 March, when I leave my present company to go on
sabbatical. I expect to get to your needs on Saturday March 9th (I'm
at ApacheCon this week and have other commitments this weekend), but
perhaps someone else can help you earlier.
I don't think any more patches are needed from you here, just more
patience. I would like us to discontinue our GitHub repository, this
team is just too small and with too limited resources to be able to
handle both IMO. Time spent on GitHub is time not spent on fixing
bugs and applying patches, but if we're to keep it then the minor
folder change you're recommending will need to be done.
Regards,
Glen
On 02/25/2013 01:35 AM, Edd Grant wrote:
Hi Glen,
Apologies for the delay in replying, have only just seen this email, for
some reason gmail was hiding it from me. Thanks to you and Dave for the
explanation of how Roller uses GitHub, I'm happy to submit an svn
patch via
JIRA. Given that I know now that GitHub is read only perhaps it would be
best if I remove the empty folder stuff from the patch and simply submit
the maven repo related change?
Cheers,
Edd
On 31 January 2013 14:00, Glen Mazza <[email protected]> wrote:
Hi, Edd, first of all many thanks for using Apache Roller!
http://www.eddgrant.com/blog/
I had no clue we had a Git mirror, but I would prefer keeping all
change
requests via patch in JIRA anyway instead of maintaining two sources of
record for change requests, i.e., let's keep the GitHub read-only
until we
retire SVN (we're a tiny project). The other project I'm aware of
that use
Git mirrors (namely, CXF) still has bug reports/patches sent via
JIRA for
others to review and comment on--AFAIK pull requests aren't used.
Your changes seem to make sense ( http://stackoverflow.com/**
questions/115983/how-do-i-add-**an-empty-directory-to-a-git-**repository<http://stackoverflow.com/questions/115983/how-do-i-add-an-empty-directory-to-a-git-repository>),
but I would need to place them in via SVN (again, fine with me). Rather
than create empty directories, it might be better to change the
build so
those empty folders wouldn't be necessary, but I don't know if/when
we can
get to that. The other change you have about the repository issue
seems to
make sense.
Glen
On 01/31/2013 08:18 AM, Dave wrote:
As far as I know, that Github is just a read only mirror of Roller. I
don't
have access to the "apache" Guthub account and cannot accept pull
requests
from it. I'll look into this, but in the meantime you may want to
submit a
traditional patch for your change.
- Dave
On Thu, Jan 31, 2013 at 3:55 AM, Edd Grant <[email protected]> wrote:
Hi all,
I submitted a pull request to Roller on GitHub 5 or so months ago.
Haven't
received any feedback on it so was just wondering if anyone is
watching
that account?
Pull request can be found here:
https://github.com/apache/**roller/pull/3(very<https://github.com/apache/roller/pull/3(very>simple,
just to do with
location of m2 repos so a fresh checkout
works for more users without modification)
If there's something wrong with the pull request just let me know and
I'll
be happy to make any corrections, or if the project isn't
interested in
the
change then that's fine but would appreciate the confirmation
either way.
Cheers,
Edd
--
Web: http://www.eddgrant.com
Email: [email protected]
Mobile: +44 (0) 7861 394 543
