From the listed changes, seems OK +1(b)

####

Spotted this one when deleting a folder:

MediaFileView.jsp

function onDeleteFolder() {
        if (confirm("<s:text name='mediaFile.deleteFolder.confirm' />")) {
            document.bookmarks.action = '<s:url action="mediaFileView!deleteFolder" />';
            document.bookmarks.submit();
        }
    }

guess it should be: document.mediaFileViewForm.action and document.mediaFileViewForm.submit();

Possibly related??


08:16:23.977 [http-nio-8080-exec-2] WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks) could not locate the message resource with key 'default' 08:16:23.977 [http-nio-8080-exec-2] WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks) could not locate the message resource with key 'default' 08:16:23.999 [http-nio-8080-exec-2] WARN org.apache.struts2.util.TextProviderHelper - The default value expression 'default' was evaluated and did not match a property. The literal value 'default' will be used. 08:16:23.999 [http-nio-8080-exec-2] WARN org.apache.struts2.util.TextProviderHelper - The default value expression 'default' was evaluated and did not match a property. The literal value 'default' will be used.

####

Also where is the bookmarks page link now?  editor-menu.xml, for weblogPerms="admin"

 <!-- globalPerms="login" -->
        <menu-item action="bookmarks"
                   name="tabbedmenu.bookmarks.allFolders"
                   weblogPerms="admin"
subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport" />

Cheers Greg

On 08/08/2021 20:57, Dave wrote:
Please vote to release the release candidate (RC2) at the link below as
Apache Roller 6.0.2
The release candidate is here
https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.2/

Please vote +1 to release or -1 with reasons not to release.


This release includes the minor changes listed below:

Parse referrer URL instead of using string value directly
https://github.com/apache/roller/pull/90

Improved: the UI for the blog entries page
https://github.com/apache/roller/pull/87

Improved: tooltip content on the registration form
https://github.com/apache/roller/pull/89

Updated: the main menu to have proper space when displaying permission
message
https://github.com/apache/roller/pull/95

Updated: the header to show the tagline only when it's available
https://github.com/apache/roller/pull/99


UI fixes are thanks to new contributor Yash Maheshwari.

Best regards,
Dave

Reply via email to