snoopdave commented on code in PR #221:
URL: https://github.com/apache/roller/pull/221#discussion_r4394330687
##########
app/src/main/java/org/apache/roller/weblogger/business/jpa/JPABookmarkManagerImpl.java:
##########
@@ -270,6 +276,26 @@ private void importOpmlElement(
}
}
+ /**
+ * Returns the value if it is an absolute http or https URL, else null.
+ */
+ static String webLinkOrNull(String value) {
Review Comment:
**Important:** `webLinkOrNull` silently drops any outline whose URL fails
`URI` parsing — including ordinary human URLs with unencoded spaces
(`http://example.com/a b`, covered by the new test). Whole bookmarks vanish
from the import with no feedback to the user beyond a debug-level log. Consider
at least logging the drop at WARN with the outline name, and a CHANGES.md note
that OPML entries are now kept only when their `htmlUrl`/`xmlUrl` are absolute
http(s) URLs, so users understand why previously-importable entries disappear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
