snoopdave commented on PR #221: URL: https://github.com/apache/roller/pull/221#issuecomment-6453912196
**🤖 GLM: PR-Review — General Issues** The following issues were found but cannot be attached to a specific line in the diff: - **Important:** CHANGES.md has no entry for this change. Other PRs in the 6.1.7 batch (e.g. #205, #208, #217) each carry one. The user-facing parts worth a note: OPML import now keeps only absolute http(s) links (entries with other URLs are dropped, including ones with unencoded spaces), and blogroll URLs reach templates only when relative or http/https/ftp/mailto — links stored by earlier versions that use other schemes now render as empty. Strengths worth noting (not action items): the two-layer approach (import-time validation plus the wrapper's scheme allow-list for stored values) covers data written before this change, and `webLinkOrNull` requiring a host is a nice strictness touch; the new tests cover both layers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
