snoopdave opened a new pull request, #271: URL: https://github.com/apache/roller/pull/271
A custom page reads `tags=` from the query string. Three rough edges: - With `entry=` also present, the tags weren't checked against the weblog, because the check sat in the last branch of the validation chain. They are now checked whenever they're given; unknown tags answer 404, as they already did without an entry. - `#showAutodiscoveryLinks` printed the tag names into the feed link titles as is. They're now HTML-encoded there, and in the Gaurav and Fauxcoly `tags_index.vm` pages. - The page cache keyed a custom page that names an entry by the entry alone, and left request tags out of custom-page keys. The key now includes the page name and the (sorted, encoded) tags. Tests: `AutodiscoveryLinksRenderingTest` renders the real macro; `WeblogPageCacheKeyTest` covers the keys. Both fail on `roller-6.1.x` and pass here. No test covers the `PageServlet` change. `mvn -pl app test`: 503 tests, 0 failures. Once this is merged, the same change goes to master for 7.0.0, where the Hyde, Terminal and PaperMod tag pages need the same encoding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
