On 1/31/18, 6:53 AM, "Yishay Weiss" <[email protected]> wrote:
>This looks very promising. I’m going to read this in batches. Some >feedback on ‘The data model’. > >repos = configurator.data.repos; > projectName = configurator.data.projectName; > >Shouldn’t these be cast to a String and an Array respectively? I didn't get any warnings. "data" should be "json". I forgot to update that. > >Also, I find these lines a bit misleading > > ><js:HTTPService id="commitsService" /> > >import org.apache.royale.events.Event; >Since some of the viewers will be first timers I think it’s important to >put code in script blocks. That's up to Andrew. He's our "editor-in-chief". > >Also, related to the last comment can you make the full source for the >example available somewhere? I will check the project into our examples folder today. Thanks for looking through it. -Alex >
