Feel free to dig in and fix it. On 2/22/18, 11:59 PM, "Piotr Zarzycki" <[email protected]> wrote:
>Your changes related to circulars helped with static Binding, but there is >still some problems with that class [1]. I've updated example with you >newest changes [2]. Take a look into the console. [2] > >[1] >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgoo.gl%2F >Y9YuuJ&data=02%7C01%7Caharui%40adobe.com%7C62158b602dd54040909f08d57a9365d >8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636549695843478010&sdata=Kh >eqXXmbDrdqvRi7v8cIkTEfg4BY0kJE%2BXrZSsImevs%3D&reserved=0 >[2] >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftranspile >dactionscript.com%2Fdev%2Fexamples%2FPureMVCEmployeeAdminBasic%2F&data=02% >7C01%7Caharui%40adobe.com%7C62158b602dd54040909f08d57a9365d8%7Cfa7b1b5a7b3 >4438794aed2c178decee1%7C0%7C0%7C636549695843478010&sdata=mTCYRquSqf9panaDU >q4bg0PVOXvuqwqBqmLVPM6ryk8%3D&reserved=0 > >Thanks, Piotr > >2018-02-23 8:50 GMT+01:00 Piotr Zarzycki <[email protected]>: > >> By turning off you mean something like this ? -> >> >>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c >>om%2Fapache%2Froyale-asjs%2Fcommit%2F&data=02%7C01%7Caharui%40adobe.com%7 >>C62158b602dd54040909f08d57a9365d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0% >>7C0%7C636549695843478010&sdata=vMaiIEtYKh7AluLq3dpGg4nJ4VxyHH5u9ukVETe4wj >>w%3D&reserved=0 >> 4d298a160aa388eb6306c6f0f80a3269ca240b40 >> >> 2018-02-23 8:48 GMT+01:00 Piotr Zarzycki <[email protected]>: >> >>> I pickup latest build and MDLTabsExample doesn't look like it should >>> be. I would like to understand what I need to do in order to get the >>>look >>> back. >>> >>> What do you mean by that: " MDL also needed to turn off default layout >>> in the Grid." >>> >>> I see that you have created that file [1] which simply force usage of >>> some fonts for the components, but that's probably not the problem. >>> Question is do I need to still use that command after your changes? >>> >>> -compiler.exclude-defaults-css-files=BasicJS.swc:defaults.css >>> >>> [1] >>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>>com%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframe&data=02%7C01%7Caharu >>>i%40adobe.com%7C62158b602dd54040909f08d57a9365d8%7Cfa7b1b5a7b34438794aed >>>2c178decee1%7C0%7C0%7C636549695843478010&sdata=mXDFaRhrIaouTe2iBG4OMG6T5 >>>BHsZ3TrRX7wdOZdjHU%3D&reserved=0 >>> works/themes/Basic/basic.css >>> >>> Thanks, Piotr >>> >>> >>> 2018-02-23 3:19 GMT+01:00 Alex Harui <[email protected]>: >>> >>>> I moved more styles from the framework to the theme to deal with the >>>> wrong >>>> layout in MDLTabsExample. >>>> >>>> MDL also needed to turn off default layout in the Grid. >>>> >>>> The data binding static variable issue turned out to be the >>>> remove-circulars code which is now on by default. I fixed that as >>>>well. >>>> >>>> Thanks for reporting these issues. >>>> -Alex >>>> >>>> On 2/22/18, 3:40 PM, "Alex Harui" <[email protected]> wrote: >>>> >>>> >Isn't that a different problem? I thought you were having problems >>>> >getting a dataProvider assigned? >>>> > >>>> >-Alex >>>> > >>>> >On 2/22/18, 3:34 PM, "piotrz" <[email protected]> wrote: >>>> > >>>> >>I'm building them using JSonly Royale and Moonshine. Tomorrow my >>>>time I >>>> >>will >>>> >>try Maven build. >>>> >> >>>> >>If I have this: >>>> >>-compiler.exclude-defaults-css-files=BasicJS.swc:defaults.css >>>>Example >>>> >>looks >>>> >>like that: >>>> >> >>>> >><https://na01.safelinks.protection.outlook.com/?url=http%3 >>>> A%2F%2Fapache-r >>>> >>o >>>> >>yale-development.20373.n8.nabble.com%2Ffile%2Ft1%2Fmdl_tab >>>> s_1.png&data=02 >>>> >>% >>>> >>7C01%7Caharui%40adobe.com%7C6738a7e848f94f4807f908d57a4ccc >>>> d2%7Cfa7b1b5a7b >>>> >>3 >>>> >>4438794aed2c178decee1%7C0%7C0%7C636549392636721475&sdata=M >>>> c8qtEBLO1%2FhT4 >>>> >>U >>>> >>P%2FBhKlpgH9r8HwU52TNDCY6Kjw2I%3D&reserved=0> >>>> >> >>>> >>If remove this: >>>> >>-compiler.exclude-defaults-css-files=BasicJS.swc:defaults.css looks >>>> like >>>> >>that: >>>> >> >>>> >><https://na01.safelinks.protection.outlook.com/?url=http%3 >>>> A%2F%2Fapache-r >>>> >>o >>>> >>yale-development.20373.n8.nabble.com%2Ffile%2Ft1%2Ftabs_2. >>>> png&data=02%7C0 >>>> >>1 >>>> >>%7Caharui%40adobe.com%7C6738a7e848f94f4807f908d57a4cccd2%7 >>>> Cfa7b1b5a7b3443 >>>> >>8 >>>> >>794aed2c178decee1%7C0%7C0%7C636549392636721475&sdata=b03fF >>>> YkV9eo903c08FEm >>>> >>o >>>> >>Y9h5QpDL3oTsfE5Kb14l%2Bs%3D&reserved=0> >>>> >> >>>> >>Thanks, Piotr >>>> >> >>>> >> >>>> >> >>>> >>-- >>>> >>Sent from: >>>> >>https://na01.safelinks.protection.outlook.com/?url=http%3A >>>> %2F%2Fapache-ro >>>> >>y >>>> >>ale-development.20373.n8.nabble.com%2F&data=02%7C01%7Caharui% >>>> 40adobe.com% >>>> >>7 >>>> >>C6738a7e848f94f4807f908d57a4cccd2%7Cfa7b1b5a7b34438794aed2 >>>> c178decee1%7C0% >>>> >>7 >>>> >>C0%7C636549392636721475&sdata=aAkqWaUnolHEe1pHN8RXBB%2BV9U >>>> g2ZcEIwesdmbYmR >>>> >>e >>>> >>M%3D&reserved=0 >>>> > >>>> >>>> >>> >>> >>> -- >>> >>> Piotr Zarzycki >>> >>> Patreon: >>>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pa >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C62158b602d >>>d54040909f08d57a9365d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365 >>>49695843478010&sdata=jLndttMkmkqFNW0y0IeWivybu9OkLmK0loWJU3zaYr8%3D&rese >>>rved=0 >>> >>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pa >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C62158b602d >>>d54040909f08d57a9365d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365 >>>49695843478010&sdata=jLndttMkmkqFNW0y0IeWivybu9OkLmK0loWJU3zaYr8%3D&rese >>>rved=0>* >>> >> >> >> >> -- >> >> Piotr Zarzycki >> >> Patreon: >>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C62158b602dd5 >>4040909f08d57a9365d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365496 >>95843478010&sdata=jLndttMkmkqFNW0y0IeWivybu9OkLmK0loWJU3zaYr8%3D&reserved >>=0 >> >><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C62158b602dd5 >>4040909f08d57a9365d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365496 >>95843478010&sdata=jLndttMkmkqFNW0y0IeWivybu9OkLmK0loWJU3zaYr8%3D&reserved >>=0>* >> > > > >-- > >Piotr Zarzycki > >Patreon: >*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C62158b602dd540 >40909f08d57a9365d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365496958 >43478010&sdata=jLndttMkmkqFNW0y0IeWivybu9OkLmK0loWJU3zaYr8%3D&reserved=0 ><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C62158b602dd540 >40909f08d57a9365d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365496958 >43478010&sdata=jLndttMkmkqFNW0y0IeWivybu9OkLmK0loWJU3zaYr8%3D&reserved=0>*
