You should not need to exclude defaults.css. We want to try to separate styles to basic.css so you don't need to.
MDLTabsExample broke with a recent change I made because MaterialDesignLite.swc is using typeNames and className inconsistently with the rest of the framework. I think we should set typeNames in the constructor instead of createElement mainly so subclasses don't have to implement createElement. So, I think if you fix that up in MaterialDesignLite, MDLTabsExample will look right again. I think I see a few other components in Basic that are still setting typeNames in createElement. -Alex On 2/22/18, 11:48 PM, "Piotr Zarzycki" <[email protected]> wrote: >I pickup latest build and MDLTabsExample doesn't look like it should be. >I >would like to understand what I need to do in order to get the look back. > >What do you mean by that: " MDL also needed to turn off default layout in >the Grid." > >I see that you have created that file [1] which simply force usage of some >fonts for the components, but that's probably not the problem. Question is >do I need to still use that command after your changes? > >-compiler.exclude-defaults-css-files=BasicJS.swc:defaults.css > >[1] >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co >m%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fthemes%2FBasic%2F >basic.css&data=02%7C01%7Caharui%40adobe.com%7C64126fc953154edfe31108d57a91 >caab%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636549688949957150&sdata >=clL%2F1w49qtY%2FJ1tXWMGRtdNkFB09U70k2gVICyySZEg%3D&reserved=0 > >Thanks, Piotr > > >2018-02-23 3:19 GMT+01:00 Alex Harui <[email protected]>: > >> I moved more styles from the framework to the theme to deal with the >>wrong >> layout in MDLTabsExample. >> >> MDL also needed to turn off default layout in the Grid. >> >> The data binding static variable issue turned out to be the >> remove-circulars code which is now on by default. I fixed that as well. >> >> Thanks for reporting these issues. >> -Alex >> >> On 2/22/18, 3:40 PM, "Alex Harui" <[email protected]> wrote: >> >> >Isn't that a different problem? I thought you were having problems >> >getting a dataProvider assigned? >> > >> >-Alex >> > >> >On 2/22/18, 3:34 PM, "piotrz" <[email protected]> wrote: >> > >> >>I'm building them using JSonly Royale and Moonshine. Tomorrow my time >>I >> >>will >> >>try Maven build. >> >> >> >>If I have this: >> >>-compiler.exclude-defaults-css-files=BasicJS.swc:defaults.css Example >> >>looks >> >>like that: >> >> >> >><https://na01.safelinks.protection.outlook.com/?url= >> http%3A%2F%2Fapache-r >> >>o >> >>yale-development.20373.n8.nabble.com%2Ffile%2Ft1%2Fmdl_ >> tabs_1.png&data=02 >> >>% >> >>7C01%7Caharui%40adobe.com%7C6738a7e848f94f4807f908d57a4c >> ccd2%7Cfa7b1b5a7b >> >>3 >> >>4438794aed2c178decee1%7C0%7C0%7C636549392636721475& >> sdata=Mc8qtEBLO1%2FhT4 >> >>U >> >>P%2FBhKlpgH9r8HwU52TNDCY6Kjw2I%3D&reserved=0> >> >> >> >>If remove this: >> >>-compiler.exclude-defaults-css-files=BasicJS.swc:defaults.css looks >>like >> >>that: >> >> >> >><https://na01.safelinks.protection.outlook.com/?url= >> http%3A%2F%2Fapache-r >> >>o >> >>yale-development.20373.n8.nabble.com%2Ffile%2Ft1%2Ftabs_ >> 2.png&data=02%7C0 >> >>1 >> >>%7Caharui%40adobe.com%7C6738a7e848f94f4807f908d57a4c >> ccd2%7Cfa7b1b5a7b3443 >> >>8 >> >>794aed2c178decee1%7C0%7C0%7C636549392636721475&sdata= >> b03fFYkV9eo903c08FEm >> >>o >> >>Y9h5QpDL3oTsfE5Kb14l%2Bs%3D&reserved=0> >> >> >> >>Thanks, Piotr >> >> >> >> >> >> >> >>-- >> >>Sent from: >> >>https://na01.safelinks.protection.outlook.com/?url= >> http%3A%2F%2Fapache-ro >> >>y >> >>>>ale-development.20373.n8.nabble.com%2F&data=02%7C01%7Caharui%40adobe.co >>>>m >> % >> >>7 >> >>C6738a7e848f94f4807f908d57a4cccd2%7Cfa7b1b5a7b34438794aed2c178de >> cee1%7C0% >> >>7 >> >>C0%7C636549392636721475&sdata=aAkqWaUnolHEe1pHN8RXBB% >> 2BV9Ug2ZcEIwesdmbYmR >> >>e >> >>M%3D&reserved=0 >> > >> >> > > >-- > >Piotr Zarzycki > >Patreon: >*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C64126fc953154e >dfe31108d57a91caab%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365496889 >49957150&sdata=XYXZgYKRsOMFvyDtUzbvKw%2Fx8qiiDIkKXtov8gpBcOg%3D&reserved=0 ><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C64126fc953154e >dfe31108d57a91caab%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365496889 >49957150&sdata=XYXZgYKRsOMFvyDtUzbvKw%2Fx8qiiDIkKXtov8gpBcOg%3D&reserved=0 >>*
