I'm sorry you were saying " write that code avoiding since the default (to Group) will be useless most of the times." - so Group in your opinion will be used not so often - just opposite than I wrote.
wt., 29 sty 2019 o 17:19 Piotr Zarzycki <[email protected]> napisał(a): > Carlos, > > Comment was your probably - i forgot to remove it. > > Comments inline. > > wt., 29 sty 2019 o 17:04 Carlos Rovira <[email protected]> > napisał(a): > >> Hi Piotr, >> >> ok I saw the problem. You are having issues trying to configure the >> content >> from the parent component (the form item itself). >> >> But looking at the code I think there's some confusion >> >> For example, the code in the FormItemView with the coment >> // add the layout bead to the content area. >> >> *Is not doing that, is setting the content area (in the current case a >> Group), this comment would be more **appropriate**:* >> >> // add the contentarea bead >> >> the solution to setup classNames like ".verticalContentFormItem " to solve >> even current solutions not seems right to me, since we'll need to always >> write that code avoiding since the default (to Group) will be useless most >> of the times. >> >> > If you are saying that users will use Group the most - than I don't see > the problem, cause with Group as a content everything is working perfectly > fine. > > >> I think we should not rely never with solutions like classes like >> FormXGroup that just setup a Gap, at least at framework level (this >> usually >> use to be part of users code) >> >> > I didn't say anywhere that I'm going to commit any of that group to > Framework. User should be responsible for creating such Group. - PAYG - I'm > showing how to do that in example. > > >> I'm going to try other solution and see if that helps you to solve this >> problem. >> >> >> > Can you say what solution are you going to try ? > > >> >> >> El mar., 29 ene. 2019 a las 16:32, Piotr Zarzycki (< >> [email protected]>) escribió: >> >> > By "my Group" - I'm not saying about Group component specifically - I'm >> > talking about component which allows you to specify that gap for example >> > VGroup. >> > >> > wt., 29 sty 2019 o 16:31 Piotr Zarzycki <[email protected]> >> > napisał(a): >> > >> > > I know that Group doesn't have gap. I'm saying that IF I would like to >> > > have children layed out differently - I will have to provide my own >> > Group - >> > > VGroup for example. >> > > >> > > IF I would like to have those children laying out vertically with gap >> - >> > my >> > > Group should come with that gap. >> > > >> > > wt., 29 sty 2019 o 16:28 Carlos Rovira <[email protected]> >> > > napisał(a): >> > > >> > >> Hi Piotr, >> > >> >> > >> I think you missed my latest response or I didn't could translate the >> > main >> > >> idea: Group doesn't have gap. So "he need >> > >> to provide appropriate Group with gap - Am I right ?" is not right to >> > >> figure that. >> > >> >> > >> >> > >> >> > >> El mar., 29 ene. 2019 a las 15:52, Piotr Zarzycki (< >> > >> [email protected]>) escribió: >> > >> >> > >> > Carlos, >> > >> > >> > >> > This one won't work. >> > >> > >> > >> > .verticalContentFormItem >> > >> > { >> > >> > IFormItemContentArea: >> > ClassReference("org.apache.royale.jewel.VGroup"); >> > >> > gap: 3; >> > >> > } >> > >> > >> > >> > Cause how that gap would be propagated to IFormItemContentArea ? I >> > think >> > >> > the solution is here if someone wanted to have gap between >> elements he >> > >> need >> > >> > to provide appropriate Group with gap - Am I right ? >> > >> > >> > >> > Thanks, >> > >> > Piotr >> > >> > >> > >> > wt., 29 sty 2019 o 11:45 Carlos Rovira <[email protected]> >> > >> > napisał(a): >> > >> > >> > >> > > Piotr, I think your problem is with having no gap between items >> > right? >> > >> > > >> > >> > > you can get it adding "gap:3" (search for that in other parts of >> > >> Jewel) >> > >> > > >> > >> > > for example: >> > >> > > >> > >> > > .verticalContentFormItem >> > >> > > { >> > >> > > IFormItemContentArea: >> > >> ClassReference("org.apache.royale.jewel.VGroup"); >> > >> > > gap: 3; >> > >> > > } >> > >> > > >> > >> > > remember to add this in sass and not in css or will be override >> when >> > >> > > generating all themes >> > >> > > >> > >> > > thanks >> > >> > > >> > >> > > >> > >> > > >> > >> > > El lun., 28 ene. 2019 a las 21:03, Piotr Zarzycki (< >> > >> > > [email protected]>) escribió: >> > >> > > >> > >> > > > Hi Guys, >> > >> > > > >> > >> > > > I just make changes which I have mention in other thread. >> > >> > > > >> > >> > > > 1. I have removed code which transfers beads through the >> > components. >> > >> > [1] >> > >> > > In >> > >> > > > the results: >> > >> > > > IBeadLayout - Is responsible for general layout of FormItem >> > >> (default: >> > >> > > > HorizontalLayout) >> > >> > > > IFormItemContentArea - Is responsible for content (default: >> Group) >> > >> > > > 2. I have removed IFormItemLayout from default.css cause it >> wasn't >> > >> used >> > >> > > > 3. I have adjusted ToureDeJewel to new changes. However there >> is >> > one >> > >> > > > problem which I need to get your thoughts how to resolve. >> > >> > > > In TourDeJewel example there is FormItem with vertical layout, >> so >> > to >> > >> > have >> > >> > > > them laying out vertically you need: >> > >> > > > >> > >> > > > 1. >> > >> > > > .verticalContentFormItem >> > >> > > > { >> > >> > > > IFormItemContentArea: >> > >> ClassReference("org.apache.royale.jewel.VGroup"); >> > >> > > > } >> > >> > > > 2. <j:FormItem label="Favorite movies (at least 2)" className=" >> > >> > > > verticalContentFormItem" />> >> > >> > > > >> > >> > > > In the results we have https://imgur.com/a/gV8DnyS - The same >> is >> > >> with >> > >> > > next >> > >> > > > item which has content HGroup. >> > >> > > > >> > >> > > > Because of that I committed my changes to >> > >> feature/formitemview_cleanup. >> > >> > > > I think as a user - I will have to create my own Group which >> > taking >> > >> > care >> > >> > > of >> > >> > > > that stuff - What do you think ? >> > >> > > > >> > >> > > > After my changes each part of FormItem is doing the right >> things >> > and >> > >> > css >> > >> > > > looks like that: >> > >> > > > >> > >> > > > j|FormItem { >> > >> > > > IBeadLayout: >> > >> > > > >> > >> > >> > >> >> > >> ClassReference("org.apache.royale.jewel.beads.layouts.HorizontalLayout"); >> > >> > > > IBeadView: >> > >> > > > >> > ClassReference("org.apache.royale.jewel.beads.views.FormItemView"); >> > >> > > > IBeadModel: >> > >> > > > >> > >> ClassReference("org.apache.royale.jewel.beads.models.FormItemModel"); >> > >> > > > IFormItemContentArea: >> > >> > ClassReference("org.apache.royale.jewel.Group"); >> > >> > > > } >> > >> > > > >> > >> > > > >> > >> > > > [1] >> > >> > > > >> > >> > > >> > >> > >> > >> >> > >> https://github.com/apache/royale-asjs/commit/2af5cc10fbe064d5176162d8c8ee54f6edd6cafb >> > >> > > > >> > >> > > > Thanks, >> > >> > > > -- >> > >> > > > >> > >> > > > Piotr Zarzycki >> > >> > > > >> > >> > > > Patreon: *https://www.patreon.com/piotrzarzycki >> > >> > > > <https://www.patreon.com/piotrzarzycki>* >> > >> > > > >> > >> > > >> > >> > > >> > >> > > -- >> > >> > > Carlos Rovira >> > >> > > http://about.me/carlosrovira >> > >> > > >> > >> > >> > >> > >> > >> > -- >> > >> > >> > >> > Piotr Zarzycki >> > >> > >> > >> > Patreon: *https://www.patreon.com/piotrzarzycki >> > >> > <https://www.patreon.com/piotrzarzycki>* >> > >> > >> > >> >> > >> >> > >> -- >> > >> Carlos Rovira >> > >> http://about.me/carlosrovira >> > >> >> > > >> > > >> > > -- >> > > >> > > Piotr Zarzycki >> > > >> > > Patreon: *https://www.patreon.com/piotrzarzycki >> > > <https://www.patreon.com/piotrzarzycki>* >> > > >> > >> > >> > -- >> > >> > Piotr Zarzycki >> > >> > Patreon: *https://www.patreon.com/piotrzarzycki >> > <https://www.patreon.com/piotrzarzycki>* >> > >> >> >> -- >> Carlos Rovira >> http://about.me/carlosrovira >> > > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>* > -- Piotr Zarzycki Patreon: *https://www.patreon.com/piotrzarzycki <https://www.patreon.com/piotrzarzycki>*
