El mar., 29 ene. 2019 a las 17:19, Piotr Zarzycki (< [email protected]>) escribió:
> > I didn't say anywhere that I'm going to commit any of that group to > Framework. User should be responsible for creating such Group. - PAYG - I'm > showing how to do that in example. > > ok, cool. But I think we need to do our best to have this easily configured with what we provide. Other thing is the user tries to do something very different, in that case is up to them to code its and plug. > Can you say what solution are you going to try ? > > I was looking at the code dedicating more time and I think the solution is already there. I just made a commit in develop that removes in the FormExample (Tour de Jewel) the surrounding HGroup and VGroup, so the FormItem is capable to use the layout we setup to layout contents in both ways, that I think is what our users will want and is the most straight forward way to do. So users will want to change the layout of the content mostly, for others that want to change the "outer" layout to have Stacked or other kind of global form item layout, that should happen with an extension of the current FormItemView to swap (while that want will be able to do what the actual one is capable right now). > > > > > > > El mar., 29 ene. 2019 a las 16:32, Piotr Zarzycki (< > > [email protected]>) escribió: > > > > > By "my Group" - I'm not saying about Group component specifically - I'm > > > talking about component which allows you to specify that gap for > example > > > VGroup. > > > > > > wt., 29 sty 2019 o 16:31 Piotr Zarzycki <[email protected]> > > > napisał(a): > > > > > > > I know that Group doesn't have gap. I'm saying that IF I would like > to > > > > have children layed out differently - I will have to provide my own > > > Group - > > > > VGroup for example. > > > > > > > > IF I would like to have those children laying out vertically with > gap - > > > my > > > > Group should come with that gap. > > > > > > > > wt., 29 sty 2019 o 16:28 Carlos Rovira <[email protected]> > > > > napisał(a): > > > > > > > >> Hi Piotr, > > > >> > > > >> I think you missed my latest response or I didn't could translate > the > > > main > > > >> idea: Group doesn't have gap. So "he need > > > >> to provide appropriate Group with gap - Am I right ?" is not right > to > > > >> figure that. > > > >> > > > >> > > > >> > > > >> El mar., 29 ene. 2019 a las 15:52, Piotr Zarzycki (< > > > >> [email protected]>) escribió: > > > >> > > > >> > Carlos, > > > >> > > > > >> > This one won't work. > > > >> > > > > >> > .verticalContentFormItem > > > >> > { > > > >> > IFormItemContentArea: > > > ClassReference("org.apache.royale.jewel.VGroup"); > > > >> > gap: 3; > > > >> > } > > > >> > > > > >> > Cause how that gap would be propagated to IFormItemContentArea ? I > > > think > > > >> > the solution is here if someone wanted to have gap between > elements > > he > > > >> need > > > >> > to provide appropriate Group with gap - Am I right ? > > > >> > > > > >> > Thanks, > > > >> > Piotr > > > >> > > > > >> > wt., 29 sty 2019 o 11:45 Carlos Rovira <[email protected]> > > > >> > napisał(a): > > > >> > > > > >> > > Piotr, I think your problem is with having no gap between items > > > right? > > > >> > > > > > >> > > you can get it adding "gap:3" (search for that in other parts of > > > >> Jewel) > > > >> > > > > > >> > > for example: > > > >> > > > > > >> > > .verticalContentFormItem > > > >> > > { > > > >> > > IFormItemContentArea: > > > >> ClassReference("org.apache.royale.jewel.VGroup"); > > > >> > > gap: 3; > > > >> > > } > > > >> > > > > > >> > > remember to add this in sass and not in css or will be override > > when > > > >> > > generating all themes > > > >> > > > > > >> > > thanks > > > >> > > > > > >> > > > > > >> > > > > > >> > > El lun., 28 ene. 2019 a las 21:03, Piotr Zarzycki (< > > > >> > > [email protected]>) escribió: > > > >> > > > > > >> > > > Hi Guys, > > > >> > > > > > > >> > > > I just make changes which I have mention in other thread. > > > >> > > > > > > >> > > > 1. I have removed code which transfers beads through the > > > components. > > > >> > [1] > > > >> > > In > > > >> > > > the results: > > > >> > > > IBeadLayout - Is responsible for general layout of FormItem > > > >> (default: > > > >> > > > HorizontalLayout) > > > >> > > > IFormItemContentArea - Is responsible for content (default: > > Group) > > > >> > > > 2. I have removed IFormItemLayout from default.css cause it > > wasn't > > > >> used > > > >> > > > 3. I have adjusted ToureDeJewel to new changes. However there > is > > > one > > > >> > > > problem which I need to get your thoughts how to resolve. > > > >> > > > In TourDeJewel example there is FormItem with vertical layout, > > so > > > to > > > >> > have > > > >> > > > them laying out vertically you need: > > > >> > > > > > > >> > > > 1. > > > >> > > > .verticalContentFormItem > > > >> > > > { > > > >> > > > IFormItemContentArea: > > > >> ClassReference("org.apache.royale.jewel.VGroup"); > > > >> > > > } > > > >> > > > 2. <j:FormItem label="Favorite movies (at least 2)" > className=" > > > >> > > > verticalContentFormItem" />> > > > >> > > > > > > >> > > > In the results we have https://imgur.com/a/gV8DnyS - The same > > is > > > >> with > > > >> > > next > > > >> > > > item which has content HGroup. > > > >> > > > > > > >> > > > Because of that I committed my changes to > > > >> feature/formitemview_cleanup. > > > >> > > > I think as a user - I will have to create my own Group which > > > taking > > > >> > care > > > >> > > of > > > >> > > > that stuff - What do you think ? > > > >> > > > > > > >> > > > After my changes each part of FormItem is doing the right > things > > > and > > > >> > css > > > >> > > > looks like that: > > > >> > > > > > > >> > > > j|FormItem { > > > >> > > > IBeadLayout: > > > >> > > > > > > >> > > > > >> > > > > ClassReference("org.apache.royale.jewel.beads.layouts.HorizontalLayout"); > > > >> > > > IBeadView: > > > >> > > > > > > ClassReference("org.apache.royale.jewel.beads.views.FormItemView"); > > > >> > > > IBeadModel: > > > >> > > > > > > >> > ClassReference("org.apache.royale.jewel.beads.models.FormItemModel"); > > > >> > > > IFormItemContentArea: > > > >> > ClassReference("org.apache.royale.jewel.Group"); > > > >> > > > } > > > >> > > > > > > >> > > > > > > >> > > > [1] > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > > > https://github.com/apache/royale-asjs/commit/2af5cc10fbe064d5176162d8c8ee54f6edd6cafb > > > >> > > > > > > >> > > > Thanks, > > > >> > > > -- > > > >> > > > > > > >> > > > Piotr Zarzycki > > > >> > > > > > > >> > > > Patreon: *https://www.patreon.com/piotrzarzycki > > > >> > > > <https://www.patreon.com/piotrzarzycki>* > > > >> > > > > > > >> > > > > > >> > > > > > >> > > -- > > > >> > > Carlos Rovira > > > >> > > http://about.me/carlosrovira > > > >> > > > > > >> > > > > >> > > > > >> > -- > > > >> > > > > >> > Piotr Zarzycki > > > >> > > > > >> > Patreon: *https://www.patreon.com/piotrzarzycki > > > >> > <https://www.patreon.com/piotrzarzycki>* > > > >> > > > > >> > > > >> > > > >> -- > > > >> Carlos Rovira > > > >> http://about.me/carlosrovira > > > >> > > > > > > > > > > > > -- > > > > > > > > Piotr Zarzycki > > > > > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > > > <https://www.patreon.com/piotrzarzycki>* > > > > > > > > > > > > > -- > > > > > > Piotr Zarzycki > > > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > > <https://www.patreon.com/piotrzarzycki>* > > > > > > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > > > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>* > -- Carlos Rovira http://about.me/carlosrovira
