We have 2-3 inject_html in Jewel that can be used to try to configure the inject_hmtl in other way. It would be great to implement some other option that not depend from a CDN load, so Jewel can "eat its own food". If someone have clear how to do that and provide one example of that I can work on turning others too.
El mar., 9 jul. 2019 a las 18:58, Alex Harui (<[email protected]>) escribió: > IMO, the ability to override the URL for an inject_html is just a missing > feature. > > My 2 cents, > -Alex > > On 7/9/19, 9:30 AM, "Josh Tynjala" <[email protected]> wrote: > > Especially if the purpose of inject_html is to load JS from a CDN. > There > will definitely be users of Royale who cannot have external > dependencies > like that, and they'll need a way to override the behavior to load a JS > file from their own server instead. > > -- > Josh Tynjala > Bowler Hat LLC < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7C027e5e7245984bd2bd3008d7048acd38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982866535082275&sdata=xLc6Lqqch8MotRZEDDr6ieJyaUIAzKznrPrdkMcmqiM%3D&reserved=0 > > > > > On Tue, Jul 9, 2019 at 9:23 AM Harbs <[email protected]> wrote: > > > I’m really not excited about the use of inject_html in Framework > code. > > > > > On Jul 9, 2019, at 7:13 PM, Carlos Rovira <[email protected] > > > > wrote: > > > > > > Hi Alex, > > > > > > El mar., 9 jul. 2019 a las 17:43, Alex Harui > (<[email protected] > > <mailto:[email protected]>>) > > > escribió: > > > > > >> IMO, adding an API for missing.js should only be done for APIs > that are > > >> truly cross-browser. If an API requires a polyfill, then if we > add it > > to > > >> missing.js and someone tries to use it on the browser that doesn't > > support > > >> it, it won't work for them without the polyfill. > > >> > > > > > > ok. another option could be to provide the inject_html for the > polyfill > > if > > > the user uses "animate" method, since the polyfill makes that > > > cross-browser. This is other abstraction or ease of development > for Royal > > > users. > > > > > > > > >> > > >> Either there should be a separate typedefs SWC for it, or we > should see > > >> what changes to the toolchain are needed to allow the missing API > to be > > >> supplied by a source extern in the SWC that uses it. > > >> > > > > > > I don't understand exactly what you propose here. I think I miss > some > > > knowledge here. > > > > > > thanks > > > > > > > > > > > >> > > >> My 2 cents, > > >> -Alex > > >> > > >> On 7/9/19, 7:57 AM, "Josh Tynjala" <[email protected]> > wrote: > > >> > > >> Generally, if we need a browser API that Closure doesn't > include in > > >> it's > > >> official externs, we add it to missing.js in the appropriate > library > > in > > >> royale-typedefs. > > >> > > >> - Josh > > >> > > >> On Tue, Jul 9, 2019, 4:39 AM Piotr Zarzycki < > > [email protected] > > >>> > > >> wrote: > > >> > > >>> I thought this is the right place, from where I should download > it > > >> to have > > >>> URLSearchParams available ? > > >>> > > >>> wt., 9 lip 2019 o 13:33 Harbs <[email protected]> > napisał(a): > > >>> > > >>>> I see you added that line. It does not look like url.js was > > >> modified in > > >>>> royale-extras. Why are you downloading it from there? > > >>>> > > >>>>> On Jul 9, 2019, at 2:26 PM, Piotr Zarzycki < > > >> [email protected]> > > >>>> wrote: > > >>>>> > > >>>>> Hi Harbs, > > >>>>> > > >>>>> Unfortunately I don't see different. externc-config.xml has > > >> url.js in > > >>>>> target/downloads/browser/url.js. > > >>>>> Ant build is downloading url.js to that folder [2]. Maven build > > >> is > > >>> doing > > >>>>> exactly the same [3]. > > >>>>> > > >>>>> What am I missing ? > > >>>>> > > >>>>> [1] > > >>>>> > > >>>> > > >>> > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-typedefs%2Fblob%2F952664e244c75f9700e7d9c14bd74283c5a75070%2Fjs%2Fsrc%2Fmain%2Fconfig%2Fexternc-config.xml%23L89&data=02%7C01%7Caharui%40adobe.com%7C027e5e7245984bd2bd3008d7048acd38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982866535082275&sdata=aWL442YiGsxTu67096Prfm4PJ%2BW1xYJS6b2VeF2zRqM%3D&reserved=0 > > >>>>> [2] > > >>>>> > > >>>> > > >>> > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-typedefs%2Fblob%2F952664e244c75f9700e7d9c14bd74283c5a75070%2Fjs%2Fbuild.xml%23L116&data=02%7C01%7Caharui%40adobe.com%7C027e5e7245984bd2bd3008d7048acd38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982866535082275&sdata=ZeoiwVyYydC6nOFPPZ4IcsU7aWfqQi6v8FCBNoRH%2Bz0%3D&reserved=0 > > >>>>> [3] > > >>>>> > > >>>> > > >>> > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-typedefs%2Fblob%2F952664e244c75f9700e7d9c14bd74283c5a75070%2Fjs%2Fpom.xml%23L192&data=02%7C01%7Caharui%40adobe.com%7C027e5e7245984bd2bd3008d7048acd38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982866535082275&sdata=i16i4ftt6yPivlcNC3I5payVhMr0h2l6G3u3Pb0nW24%3D&reserved=0 > > >>>>> > > >>>>> Thanks, > > >>>>> Piotr > > >>>>> > > >>>>> wt., 9 lip 2019 o 11:06 Harbs <[email protected]> > > >> napisał(a): > > >>>>> > > >>>>>> Take a look at the following files in the typedef repo: > > >>>>>> Lines 108-166 in build.xml > > >>>>>> Line 67 and later in pom.xml > > >>>>>> Notice the different paths in externc-config.xml > > >>>>>> > > >>>>>>> On Jul 9, 2019, at 11:57 AM, Carlos Rovira < > > >> [email protected]> > > >>>>>> wrote: > > >>>>>>> > > >>>>>>> So I can add Web Animations API externs there, but this will > > >> trigger > > >>>> some > > >>>>>>> build in extras and royale will pick that in the next build? > > >> I'm > > >>>> figuring > > >>>>>>> if something must be done I extras or just committing there > is > > >> all > > >>> that > > >>>>>> is > > >>>>>>> needed > > >>>>>> > > >>>>>> > > >>>>> > > >>>>> -- > > >>>>> > > >>>>> Piotr Zarzycki > > >>>>> > > >>>>> Patreon: * > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C027e5e7245984bd2bd3008d7048acd38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982866535092267&sdata=I0W9Os7N5On8dbF4atBZF8j2SwlETtnpu4D%2FJeLuXyM%3D&reserved=0 > > >>>>> < > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C027e5e7245984bd2bd3008d7048acd38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982866535092267&sdata=I0W9Os7N5On8dbF4atBZF8j2SwlETtnpu4D%2FJeLuXyM%3D&reserved=0 > > >>> * > > >>>> > > >>>> > > >>> > > >>> -- > > >>> > > >>> Piotr Zarzycki > > >>> > > >>> Patreon: * > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C027e5e7245984bd2bd3008d7048acd38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982866535092267&sdata=I0W9Os7N5On8dbF4atBZF8j2SwlETtnpu4D%2FJeLuXyM%3D&reserved=0 > > >>> < > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C027e5e7245984bd2bd3008d7048acd38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982866535092267&sdata=I0W9Os7N5On8dbF4atBZF8j2SwlETtnpu4D%2FJeLuXyM%3D&reserved=0 > > >>> * > > >>> > > >> > > >> > > >> > > > > > > -- > > > Carlos Rovira > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C027e5e7245984bd2bd3008d7048acd38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982866535092267&sdata=sARoL2n%2BCO9yWvA9UeBwOPejVsejZcSIMyJ6onCaI3s%3D&reserved=0 > < > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C027e5e7245984bd2bd3008d7048acd38%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636982866535092267&sdata=sARoL2n%2BCO9yWvA9UeBwOPejVsejZcSIMyJ6onCaI3s%3D&reserved=0 > > > > > > > -- Carlos Rovira http://about.me/carlosrovira
