Thanks Josh! I can see it working all again :) El sáb., 21 mar. 2020 a las 0:02, Josh Tynjala (<joshtynj...@bowlerhat.dev>) escribió:
> This seems to be caused by my recent commit to the compiler related to > class/interface exports. Sorry about that! I've reverted for now so that > I'm not holding up anyone's work. I'll try adding the change again (with > some tweaks) another day. Or Greg said that he might look into it too. > > (What's very strange is that I tested a release build of TourDeJewel before > pushing my commit, and everything was definitely working fine. Now, the > failure is obvious on my computer too, so I don't know how I could have > possibly missed that.) > > Anyway, sorry again! > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Thu, Mar 19, 2020 at 7:40 AM Piotr Zarzycki <piotrzarzyck...@gmail.com> > wrote: > > > Carlos, > > > > I have found issue after couple of hours of searching. It is reproducible > > in TourDeJewel -> Button playground - release version of build. Following > > code doesn't work at all: > > > > <j:Button text="Primary" emphasis="{StyledUIBase.PRIMARY}"/> > > > > Static variable PRIMARY is note being setup. We are using static vars to > > set name of the content and that's why in our app no content is being > > displayed: > > > > <j:ScrollableSectionContent name="{MyClass.NAME}"> > > > > </j:ScrollableSectionContent> > > > > Greg do you see anything related to latest changes in Binding area ? > > > > Thanks, > > Piotr > > > > > > czw., 19 mar 2020 o 13:54 Piotr Zarzycki <piotrzarzyck...@gmail.com> > > napisał(a): > > > > > I'm trying to find that, but currently in release mode navigation > doesn't > > > work at all - I moved back to the oldest build [1] and have same issue. > > In > > > the other words in release mode I don't see any content at all. I'm > going > > > to prepare separate example which shows that issue. > > > > > > [1] > > > > > > http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/1051/ > > > > > > czw., 19 mar 2020 o 13:46 Carlos Rovira <carlosrov...@apache.org> > > > napisał(a): > > > > > >> Hi Piotr, > > >> can you share how it was looking until now? > > >> Other option is to find from where commit started to fail > > >> > > >> > > >> El jue., 19 mar. 2020 a las 12:07, Piotr Zarzycki (< > > >> piotrzarzyck...@gmail.com>) escribió: > > >> > > >> > Hi Carlos, > > >> > > > >> > Your latest changes to containers messed up our UI in app. [1] I > will > > >> > adjust it, but I'm really not sure what is actually happen that we > > have > > >> so > > >> > much mess there. > > >> > > > >> > [1] https://ibb.co/CPkxx8S > > >> > > > >> > Thanks, > > >> > Piotr > > >> > > > >> > śr., 18 mar 2020 o 16:57 Carlos Rovira <carlosrov...@apache.org> > > >> > napisał(a): > > >> > > > >> > > Hi Alex, > > >> > > > > >> > > I'll try your sugestion about the flex grow. I revised the flex > box > > >> code > > >> > > and in fact columns right now does not use flex config > > >> > > thanks > > >> > > > > >> > > El mié., 18 mar. 2020 a las 16:45, Alex Harui > > >> (<aha...@adobe.com.invalid > > >> > >) > > >> > > escribió: > > >> > > > > >> > > > > > >> > > > > > >> > > > On 3/18/20, 3:12 AM, "Carlos Rovira" <carlosrov...@apache.org> > > >> wrote: > > >> > > > > > >> > > > Hi Alex, > > >> > > > > > >> > > > I'm experimenting for this concrete case with a calc(% - px) > > >> > formula > > >> > > > that > > >> > > > could work. don't like it so much since it means is > something > > >> very > > >> > > "JS" > > >> > > > coupled but it should maintain responsiveness. Crossing > > fingers > > >> :) > > >> > > > > > >> > > > IMO, there is something already "very JS" in the code. You are > > >> using > > >> > > > display="flex" instead of running a layout pass on each > container > > >> and > > >> > > > child. Which is the right thing to do, IMO, but has > implications. > > >> If > > >> > > your > > >> > > > calc idea doesn't work out, I wonder what would happen if you > > simply > > >> > > > translated percentWidth on the columns to flexGrow or whatever > > >> > attributes > > >> > > > give relative sizes to the children in a flexbox. > > >> > > > > > >> > > > -Alex > > >> > > > > > >> > > > El mié., 18 mar. 2020 a las 3:44, Alex Harui > > >> > > (<aha...@adobe.com.invalid > > >> > > > >) > > >> > > > escribió: > > >> > > > > > >> > > > > > > >> > > > > > > >> > > > > On 3/17/20, 5:14 PM, "Carlos Rovira" < > > carlosrov...@apache.org > > >> > > > >> > > > wrote: > > >> > > > > > > >> > > > > Hi Alex, > > >> > > > > > > >> > > > > I'll try to see how things are done in MXRoyale's ADG > > for > > >> > > > columns. > > >> > > > > Really > > >> > > > > the problem right now is in that concrete case. I'm > sure > > >> > > there's > > >> > > > some > > >> > > > > way > > >> > > > > to do it but while I'm using flex box already as you > > >> suggest > > >> > > for > > >> > > > many > > >> > > > > things, in this case I need to do calculations, since > > all > > >> is > > >> > > > based on > > >> > > > > how > > >> > > > > users will configure the columns via mxml with a mix > (or > > >> not) > > >> > > of > > >> > > > > pixels and > > >> > > > > percentages. > > >> > > > > > > >> > > > > And because you are using display="flex", not having the > > child > > >> > > > columns > > >> > > > > also be CSS compliant with the width is probably causing > the > > >> > pain. > > >> > > > That's > > >> > > > > what I saw with MXRoyale. > > >> > > > > You may be able to calculate the numbers, but then the > > columns > > >> > will > > >> > > > not be > > >> > > > > responsive as the "flex" container changes size. You will > > >> have > > >> > to > > >> > > > detect > > >> > > > > that and recompute. > > >> > > > > > > >> > > > > If you instead using the weighting system that "flex" > > children > > >> > > use, I > > >> > > > > think you will have less pain and more responsive-ness. > > Users > > >> > > might > > >> > > > gladly > > >> > > > > give up on the old Flex percentWidth overloading in favor > of > > >> the > > >> > > > weighting > > >> > > > > system to get that responsiveness. > > >> > > > > > > >> > > > > My 2 cents, > > >> > > > > -Alex > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > >> > > > -- > > >> > > > Carlos Rovira > > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cc089fb86c6e9419f5a5d08d7cb24d510%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637201231364732539&sdata=sl2FCZYFAeC9gGjhlZIK1TMTkxQCtsUjJgmqIOS0xWo%3D&reserved=0 > > >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > -- > > >> > > Carlos Rovira > > >> > > http://about.me/carlosrovira > > >> > > > > >> > > > >> > > > >> > -- > > >> > > > >> > Piotr Zarzycki > > >> > > > >> > Patreon: *https://www.patreon.com/piotrzarzycki > > >> > <https://www.patreon.com/piotrzarzycki>* > > >> > > > >> > > >> > > >> -- > > >> Carlos Rovira > > >> http://about.me/carlosrovira > > >> > > > > > > > > > -- > > > > > > Piotr Zarzycki > > > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > > <https://www.patreon.com/piotrzarzycki>* > > > > > > > > > -- > > > > Piotr Zarzycki > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > <https://www.patreon.com/piotrzarzycki>* > > > -- Carlos Rovira http://about.me/carlosrovira
