Only at the top level. The maven build should have failed. I just pushed the
fix for it.
On 4/17/20, 2:57 AM, "Yishay Weiss" <yishayj...@hotmail.com> wrote:
I don’t see any license headers to other md files. Aren’t they filtered out
of the RAT check?
From: Carlos Rovira<mailto:carlosrov...@apache.org>
Sent: Friday, April 17, 2020 12:34 PM
To: Apache Royale Development<mailto:dev@royale.apache.org>
Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
Hi Yishay,
not sure but probably the empty file added will cause RAT problems with
maven
maybe you should see if that happens and at least add a license header
About content, since is taken from the git history I think is ok
thanks
El vie., 17 abr. 2020 a las 10:14, Yishay Weiss (<yishayj...@hotmail.com>)
escribió:
> Ok Carlos, thanks. I created RELEASE_NOTES.md under compiler-build-tools.
> I think the main contributors since 1.1 [1] are Alex and Chris so it would
> be great if they could add their comments there.
>
>
>
> [1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fkmw0k&data=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248566154&sdata=WxQXt15d89UFzn6s%2Fx1szRvzEvrX%2FPadPyHWZqNvZfM%3D&reserved=0
>
>
>
> *From:* Carlos Rovira <carlosrov...@apache.org>
> *Sent:* Wednesday, April 15, 2020 11:29:04 AM
> *To:* Apache Royale Development <dev@royale.apache.org>
> *Subject:* Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
>
>
>
> Hi Yishay,
>
> build tools and jburg was never released on its own before. Always was
part
> of the global royale release. This is the first time we do this.
>
> Thanks
>
> El mié., 15 abr. 2020 a las 10:21, Yishay Weiss (<yishayj...@hotmail.com>)
> escribió:
>
> > I’ve just noticed the subject should be changed to
> >
> > [DISCUSS] Release Apache Royale Compiler Build Tools 1.2.0. Looks like a
> > bug in CI step 6.
> >
> > Anyway, the vote has passed. I haven’t seen previous announcements on
> > compiler build tools. Has this been done in the past? Can anyone point
me
> > to an example?
> >
> > Thanks.
> >
> > From: Greg Dove<mailto:greg.d...@gmail.com <greg.d...@gmail.com>>
> > Sent: Tuesday, April 14, 2020 9:27 PM
> > To: Apache Royale Development<mailto:dev@royale.apache.org
> <dev@royale.apache.org>>
> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
> >
> > fyi I can't get to this until my current EOD, about 12 hours from now. I
> > will remind myself what I need to do and check it then and vote, if the
> > voting is still open (I understand it may not be, as I think the
> threshold
> > was already passed).
> >
> >
> >
> > On Wed, Apr 15, 2020 at 6:03 AM Carlos Rovira <carlosrov...@apache.org>
> > wrote:
> >
> > > Remember that we have Maven Wrapper [1] in our repo so if you don't
> have
> > > maven installed you can just use "mvnw" (Mac) or "mvnw.cmd" (Win) and
> > that
> > > will install maven for you :)
> > >
> > > [1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftakari%2Fmaven-wrapper&data=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248566154&sdata=2KdG3HXYRtkAP0vvvJgRtbVsUjk%2BXrp%2FQpCr7TUYEP0%3D&reserved=0
> > >
> > > El mar., 14 abr. 2020 a las 18:05, Josh Tynjala (<
> > > joshtynj...@bowlerhat.dev>)
> > > escribió:
> > >
> > > > If you're on Windows, and you happened to install Maven using the
> > > > Chocolatey package manager, you may need to tweak the
> > > ApproveBuildTools.xml
> > > > file to get it to work.
> > > >
> > > > Find this line:
> > > >
> > > > <condition property="mvn" value="mvn.cmd">
> > > >
> > > > And change it to this:
> > > >
> > > > <condition property="mvn" value="mvn.exe">
> > > >
> > > > I think that most people will be fine, but I just wanted to mention
> it.
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC
<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248576147&sdata=fPGtDx6MhjtfyvHwzoE9%2BFC5aVQZxcL232lcU2Z%2Fk7s%3D&reserved=0>
> > > >
> > > >
> > > > On Mon, Apr 13, 2020 at 1:33 PM <apacheroyal...@gmail.com> wrote:
> > > >
> > > > > This is the discussion thread.
> > > > >
> > > > > Thanks,
> > > > > Yishay Weiss
> > > >
> > >
> > >
> > > --
> > > Carlos Rovira
> > >
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248576147&sdata=PbZNxbS1Rs09AdjnVxu4%2Fxph2tHTEtLZMD9k7iDPwvs%3D&reserved=0
> > >
> >
> >
>
> --
> Carlos Rovira
>
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248576147&sdata=PbZNxbS1Rs09AdjnVxu4%2Fxph2tHTEtLZMD9k7iDPwvs%3D&reserved=0
>
> *From: *Carlos Rovira <carlosrov...@apache.org>
> *Sent: *Wednesday, April 15, 2020 11:29 AM
> *To: *Apache Royale Development <dev@royale.apache.org>
> *Subject: *Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
>
>
>
> Hi Yishay,
>
> build tools and jburg was never released on its own before. Always was
part
> of the global royale release. This is the first time we do this.
>
> Thanks
>
> El mié., 15 abr. 2020 a las 10:21, Yishay Weiss (<yishayj...@hotmail.com>)
> escribió:
>
> > I’ve just noticed the subject should be changed to
> >
> > [DISCUSS] Release Apache Royale Compiler Build Tools 1.2.0. Looks like a
> > bug in CI step 6.
> >
> > Anyway, the vote has passed. I haven’t seen previous announcements on
> > compiler build tools. Has this been done in the past? Can anyone point
me
> > to an example?
> >
> > Thanks.
> >
> > From: Greg Dove<mailto:greg.d...@gmail.com <greg.d...@gmail.com>>
> > Sent: Tuesday, April 14, 2020 9:27 PM
> > To: Apache Royale Development<mailto:dev@royale.apache.org
> <dev@royale.apache.org>>
> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 1.2.0
> >
> > fyi I can't get to this until my current EOD, about 12 hours from now. I
> > will remind myself what I need to do and check it then and vote, if the
> > voting is still open (I understand it may not be, as I think the
> threshold
> > was already passed).
> >
> >
> >
> > On Wed, Apr 15, 2020 at 6:03 AM Carlos Rovira <carlosrov...@apache.org>
> > wrote:
> >
> > > Remember that we have Maven Wrapper [1] in our repo so if you don't
> have
> > > maven installed you can just use "mvnw" (Mac) or "mvnw.cmd" (Win) and
> > that
> > > will install maven for you :)
> > >
> > > [1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftakari%2Fmaven-wrapper&data=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248576147&sdata=6%2FJCpJuUJNKUKzeYEuEBzTVl5uyEYofh%2B%2FoMSzD3qrg%3D&reserved=0
> > >
> > > El mar., 14 abr. 2020 a las 18:05, Josh Tynjala (<
> > > joshtynj...@bowlerhat.dev>)
> > > escribió:
> > >
> > > > If you're on Windows, and you happened to install Maven using the
> > > > Chocolatey package manager, you may need to tweak the
> > > ApproveBuildTools.xml
> > > > file to get it to work.
> > > >
> > > > Find this line:
> > > >
> > > > <condition property="mvn" value="mvn.cmd">
> > > >
> > > > And change it to this:
> > > >
> > > > <condition property="mvn" value="mvn.exe">
> > > >
> > > > I think that most people will be fine, but I just wanted to mention
> it.
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC
<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248576147&sdata=fPGtDx6MhjtfyvHwzoE9%2BFC5aVQZxcL232lcU2Z%2Fk7s%3D&reserved=0>
> > > >
> > > >
> > > > On Mon, Apr 13, 2020 at 1:33 PM <apacheroyal...@gmail.com> wrote:
> > > >
> > > > > This is the discussion thread.
> > > > >
> > > > > Thanks,
> > > > > Yishay Weiss
> > > >
> > >
> > >
> > > --
> > > Carlos Rovira
> > >
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248576147&sdata=PbZNxbS1Rs09AdjnVxu4%2Fxph2tHTEtLZMD9k7iDPwvs%3D&reserved=0
> > >
> >
> >
>
> --
> Carlos Rovira
>
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248576147&sdata=PbZNxbS1Rs09AdjnVxu4%2Fxph2tHTEtLZMD9k7iDPwvs%3D&reserved=0
>
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C059fd98a81634407247d08d7e2b5ae1f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637227142248576147&sdata=PbZNxbS1Rs09AdjnVxu4%2Fxph2tHTEtLZMD9k7iDPwvs%3D&reserved=0
