@Chris you're right, sorry, I didn't download your last commit.
I'm sorry.
Hiedra.

-----Mensaje original-----
De: Christofer Dutz <christofer.d...@c-ware.de> 
Enviado el: viernes, 19 de febrero de 2021 10:17
Para: dev@royale.apache.org
Asunto: AW: Align Maven IDE distribution with Ant IDE distribution

I'll try to guess what you wanted to say here ...

But I think these are exactly the changes I comitted a an hour ago, right?
At least in general I replaced all the references to names with versions to the 
changed ones.


Chris



-----Ursprüngliche Nachricht-----
Von: Maria Jose Esteve <mjest...@iest.com>
Gesendet: Freitag, 19. Februar 2021 10:01
An: dev@royale.apache.org
Betreff: RE: Align Maven IDE distribution with Ant IDE distribution

Hi,
Mi distribución hace referencia en el fichero "./frameworks/royale-config.xml" 
a las librerías:

      <js-external-library-path>
          
<path-element>../js/libs/royale-typedefs-js-0.9.8-SNAPSHOT-typedefs.swc</path-element>
          
<path-element>../js/libs/royale-typedefs-gcl-0.9.8-SNAPSHOT-typedefs.swc</path-element>
      </js-external-library-path>

Las correctas son:

      <js-external-library-path>
          <path-element>../js/libs/royale-typedefs-js.swc</path-element>
          <path-element>../js/libs/royale-typedefs-gcl.swc</path-element>
      </js-external-library-path>

Hiedra

-----Mensaje original-----
De: Christofer Dutz <christofer.d...@c-ware.de> Enviado el: viernes, 19 de 
febrero de 2021 9:39
Para: dev@royale.apache.org
Asunto: AW: Align Maven IDE distribution with Ant IDE distribution

Ok,

so the config xml files in the distribution were still pointing to the old 
names. I updated them all to now refer to the names.
I tried things in Carlos' demo project, and I'm no-longer getting the errors, 
however compilation seems to take for ever.

Please try out the changes and tell me if there are any problems with them.

Chris

-----Ursprüngliche Nachricht-----
Von: Christofer Dutz <christofer.d...@c-ware.de>
Gesendet: Donnerstag, 18. Februar 2021 23:17
An: dev@royale.apache.org
Betreff: AW: Align Maven IDE distribution with Ant IDE distribution

Hi Carlos,

I'll look into this tomorrow.

Chris

-----Ursprüngliche Nachricht-----
Von: Carlos Rovira <carlosrov...@apache.org>
Gesendet: Donnerstag, 18. Februar 2021 17:49
An: Apache Royale Development <dev@royale.apache.org>
Betreff: Re: Align Maven IDE distribution with Ant IDE distribution

Hi, I think I talked very quickly, sorry, there seems to be a problem.

@Christofer Dutz <christofer.d...@c-ware.de> you can download this project:

https://github.com/apache/royale-asjs/files/6004363/ToggleButtonBarIssue.zip

Then using VSCode with AS3&MXML and adding the Maven distribution.
Then hit CTRL+ENTER and you will get the following fail. Using ANT distribution 
is working fine.
Can you take a look?

Royale Compiler Shell
(fcsh) mxmlc --debug=false +configname=royale --targets=JSRoyale 
--source-map=true --html-template=src/html/jewel-example-index-template.html
--theme=${royalelib}/themes/Jewel-Light-Flat-Primary-Sapphire-Theme/src/main/resources/defaults.css
--source-path+=src --library-path+=${royalelib}/js/libs/MXRoyaleJS.swc
--js-library-path+=${royalelib}/js/libs/MXRoyaleJS.swc
-compiler.exclude-defaults-css-files=MXRoyaleJS.swc:defaults.css
-js-dynamic-access-unknown-members=true -- src/App.mxml
fcsh: Assigned 1 as the compile target id The project 'App' has been 
successfully compiled and optimized.
Compile status: 0
Elapsed time: 14.211105399 seconds
Feb 18, 2021 5:43:40 PM com.google.javascript.jscomp.LoggerErrorManager
printSummary
INFO: 0 error(s), 0 warning(s), 96.5% typed
(fcsh) quit
Compiler shell exited with code: 0
Royale Compiler Shell
(fcsh) mxmlc --debug=false +configname=royale --targets=JSRoyale 
--source-map=true --html-template=src/html/jewel-example-index-template.html
--theme=${royalelib}/themes/Jewel-Light-Flat-Primary-Sapphire-Theme/src/main/resources/defaults.css
--source-path+=src --library-path+=${royalelib}/js/libs/MXRoyaleJS.swc
--js-library-path+=${royalelib}/js/libs/MXRoyaleJS.swc
-compiler.exclude-defaults-css-files=MXRoyaleJS.swc:defaults.css
-js-dynamic-access-unknown-members=true -- src/App.mxml
fcsh: Assigned 1 as the compile target id Compile status: 5 Elapsed time: 
0.618407478 seconds
/Users/carlosrovira/Dev/Royale/Sdks/apache-royale-maven/frameworks/royale-config.xml(81):
col: 0 Error: unable to open
'/Users/carlosrovira/Dev/Royale/Sdks/apache-royale-maven/js/libs/royale-typedefs-js-0.9.8-SNAPSHOT-typedefs.swc'.
/Users/carlosrovira/Dev/Royale/Sdks/apache-royale-maven/frameworks/royale-config.xml
(line: 81)

</js-external-library-path>


/Users/carlosrovira/Dev/Royale/Sdks/apache-royale-maven/frameworks/royale-config.xml(81):
col: 0 Error: unable to open
'/Users/carlosrovira/Dev/Royale/Sdks/apache-royale-maven/js/libs/royale-typedefs-gcl-0.9.8-SNAPSHOT-typedefs.swc'.
/Users/carlosrovira/Dev/Royale/Sdks/apache-royale-maven/frameworks/royale-config.xml
(line: 81)

</js-external-library-path>
(fcsh)
Quick Compile failed. Errors in compiler output.

El jue, 18 feb 2021 a las 17:26, Carlos Rovira (<carlosrov...@apache.org>)
escribió:

> Hi,
>
> I rebuilt all from scratch just now and finally the distribution too 
> and tried in VSCode and all seems to work fine for me.
>
> El jue, 18 feb 2021 a las 16:30, Christofer Dutz (<
> christofer.d...@c-ware.de>) escribió:
>
>> Hi Piotr,
>>
>> that class is located in lib\external\flex-tool-api.jar At least in 
>> my distribution it's there and it contains the class.
>>
>> How are you calling the build that's failing?
>>
>> Chris
>>
>> -----Ursprüngliche Nachricht-----
>> Von: Piotr Zarzycki <piotrzarzyck...@gmail.com>
>> Gesendet: Donnerstag, 18. Februar 2021 16:22
>> An: Apache Royale Development <dev@royale.apache.org>
>> Betreff: Re: Align Maven IDE distribution with Ant IDE distribution
>>
>> Chris,
>>
>> I just checked and I'm not able build project anymore using distribution:
>>
>> : Using Royale SDK: "D:\Work\royale_ide\distribution"
>> : Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms356m 
>> -Xmx3000m
>> : Error: Could not find or load main class 
>> org.apache.royale.compiler.clients.MXMLJSC
>> : Caused by: java.lang.NoClassDefFoundError:
>> org/apache/flex/tools/FlexTool
>>
>> I'm done for today, so I will answer anything tomorrow.
>>
>> czw., 18 lut 2021 o 16:05 Christofer Dutz <christofer.d...@c-ware.de>
>> napisał(a):
>>
>> > Ok ...
>> >
>> > so I just pushed another change. Now the distribution should also 
>> > contain an empty spark.css, just like the Ant one.
>> >
>> > Chris
>> >
>> >
>> > -----Ursprüngliche Nachricht-----
>> > Von: Christofer Dutz <christofer.d...@c-ware.de>
>> > Gesendet: Donnerstag, 18. Februar 2021 15:58
>> > An: dev@royale.apache.org
>> > Betreff: AW: Align Maven IDE distribution with Ant IDE distribution
>> >
>> > Ok,
>> >
>> > so that should now be fixed. Leaves the "spark.css"
>> > Having had a look, it seems as if the Ant build creates an empty
>> spark.css.
>> >
>> > Is this all we need? If yes, then I'll have that in ther in no time.
>> >
>> > Chris
>> >
>> > -----Ursprüngliche Nachricht-----
>> > Von: Piotr Zarzycki <piotrzarzyck...@gmail.com>
>> > Gesendet: Donnerstag, 18. Februar 2021 15:54
>> > An: Apache Royale Development <dev@royale.apache.org>
>> > Betreff: Re: Align Maven IDE distribution with Ant IDE distribution
>> >
>> > *(I assume that's in the "frameworks/js/libs" directory? *
>> >
>> > Yes this is the directory.
>> >
>> > czw., 18 lut 2021 o 15:51 Christofer Dutz 
>> > <christofer.d...@c-ware.de>
>> > napisał(a):
>> >
>> > > Hi Piotr,
>> > >
>> > > Ok ... so Ant seems to be adding a "JS" to the end of every name 
>> > > (I assume that's in the "frameworks/js/libs" directory?
>> > >
>> > > Also I'll try to find out where the "spark.css" should come from ...
>> > > and where it should go to.
>> > >
>> > > Chris
>> > >
>> > >
>> > > -----Ursprüngliche Nachricht-----
>> > > Von: Piotr Zarzycki <piotrzarzyck...@gmail.com>
>> > > Gesendet: Donnerstag, 18. Februar 2021 15:47
>> > > An: Apache Royale Development <dev@royale.apache.org>
>> > > Betreff: Re: Align Maven IDE distribution with Ant IDE 
>> > > distribution
>> > >
>> > > Chris,
>> > >
>> > > Looks better but here is the comparision what I have in Ant 
>> > > distribution vs Maven distribution in case of names. On the left 
>> > > Ant distribution, on the right Maven. It is folder:
>> > > frameworks\js\libs\ [1]
>> > >
>> > > [1] https://ibb.co/W2DzcDb
>> > >
>> > > czw., 18 lut 2021 o 15:22 Christofer Dutz 
>> > > <christofer.d...@c-ware.de>
>> > > napisał(a):
>> > >
>> > > > And done ...
>> > > >
>> > > > Now all elements in the distribution only consist of their name 
>> > > > and file-ending ... all versions and classifiers have been removed.
>> > > > Please provide me with feedback on if this solves the issues.
>> > > >
>> > > > Chris
>> > > >
>> > > >
>> > > > -----Ursprüngliche Nachricht-----
>> > > > Von: Christofer Dutz <christofer.d...@c-ware.de>
>> > > > Gesendet: Donnerstag, 18. Februar 2021 15:08
>> > > > An: dev@royale.apache.org
>> > > > Betreff: AW: Align Maven IDE distribution with Ant IDE 
>> > > > distribution
>> > > >
>> > > > I'll probably have a fix for that in a few minuntes ...
>> > > >
>> > > >
>> > > > Chris
>> > > >
>> > > >
>> > > > -----Ursprüngliche Nachricht-----
>> > > > Von: Piotr Zarzycki <piotrzarzyck...@gmail.com>
>> > > > Gesendet: Donnerstag, 18. Februar 2021 15:00
>> > > > An: Apache Royale Development <dev@royale.apache.org>
>> > > > Betreff: Re: Align Maven IDE distribution with Ant IDE 
>> > > > distribution
>> > > >
>> > > > Chris,
>> > > >
>> > > > No it's not about not picking up by IDE at all. Moonshine and 
>> > > > VSCode are able to build projects using Maven distribution 
>> > > > package! It is about project which are mixed for example when 
>> > > > user wanted to use Jewel module + RemoteObject class from 
>> > > > MXRoyale module. In that case user need to point explicilty as 
>> > > > a compiler options in IDE that he wanted to have SWC included 
>> > > > and need to exclude css from that swc to
>> > > avoid problems.
>> > > >
>> > > > It is happen like that:
>> > > >
>> > > >   -js-library-path+=${royalelib}/js/libs/MXRoyaleJS.swc
>> > > > -compiler.exclude-defaults-css-files=MXRoyaleJS.swc:defaults.cs
>> > > > s
>> > > >
>> > > > If I would like to use maven distribution user need to know 
>> > > > version for that compiler options. It is even more tricky when 
>> > > > your swc is called
>> > > > -> MXRoyale-0.9.8-20210217.181012-913-js.swc
>> > > >
>> > > > -exclude-defaults-css-files=MXRoyale-0.9.8-js.swc:defaults.css
>> > > >
>> > > > Thanks,
>> > > > Piotr
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > czw., 18 lut 2021 o 14:47 Christofer Dutz 
>> > > > <christofer.d...@c-ware.de>
>> > > > napisał(a):
>> > > >
>> > > > > Hi Piotr,
>> > > > >
>> > > > > And is really the version-suffix causing it to not be picked 
>> > > > > up by the IDEs?
>> > > > >
>> > > > > Chris
>> > > > >
>> > > > > -----Ursprüngliche Nachricht-----
>> > > > > Von: Piotr Zarzycki <piotrzarzyck...@gmail.com>
>> > > > > Gesendet: Donnerstag, 18. Februar 2021 11:42
>> > > > > An: dev@royale.apache.org
>> > > > > Betreff: Re: Align Maven IDE distribution with Ant IDE 
>> > > > > distribution
>> > > > >
>> > > > > Hi Chris,
>> > > > >
>> > > > > This is the only thing which seems to be a constant problem here.
>> > > > > I personally and some users will be much more happy having 
>> > > > > that
>> > change.
>> > > > >
>> > > > > Thanks,
>> > > > > Piotr
>> > > > >
>> > > > > On Thu, 18 Feb 2021 at 11:03, Christofer Dutz 
>> > > > > <christofer.d...@c-ware.de>
>> > > > > wrote:
>> > > > >
>> > > > > > Hi Piotr,
>> > > > > >
>> > > > > > I'd be happy to help with that.
>> > > > > >
>> > > > > > I did simply ask for a list of things that need to be 
>> > > > > > changed in order to get things working, but never got said 
>> > > > > > list, so I never knew what I could do to make the Maven 
>> > > > > > distribution match up to the
>> > > > Ant built one.
>> > > > > >
>> > > > > > Chris
>> > > > > >
>> > > > > >
>> > > > > > -----Ursprüngliche Nachricht-----
>> > > > > > Von: Piotr Zarzycki <piotrzarzyck...@gmail.com>
>> > > > > > Gesendet: Donnerstag, 18. Februar 2021 11:01
>> > > > > > An: Apache Royale Development <dev@royale.apache.org>
>> > > > > > Betreff: Align Maven IDE distribution with Ant IDE 
>> > > > > > distribution
>> > > > > >
>> > > > > > Hi Guys,
>> > > > > >
>> > > > > > It's been couple of times when user complains that he have 
>> > > > > > problems with using Maven distribution vs Ant distribution 
>> > > > > > in IDE in a mixed project Jewel + MX/Spark etc.
>> > > > > >
>> > > > > > Can we have that resolve once for all and adjust Maven 
>> > > > > > distribution folder to produce proper names of swcs ?
>> > > > > >
>> > > > > > Currently when I build Maven IDE distribution I have:
>> > > > > >
>> > > > > > MXRoyale-0.9.8-20210215.234230-908-js.swc
>> > > > > >
>> > > > > > When I build Ant IDE distribution I have:
>> > > > > >
>> > > > > >   MXRoyale-js.swc
>> > > > > >
>> > > > > > Thanks,
>> > > > > > --
>> > > > > >
>> > > > > > Piotr Zarzycki
>> > > > > >
>> > > > > --
>> > > > >
>> > > > > Piotr Zarzycki
>> > > > >
>> > > >
>> > > >
>> > > > --
>> > > >
>> > > > Piotr Zarzycki
>> > > >
>> > >
>> > >
>> > > --
>> > >
>> > > Piotr Zarzycki
>> > >
>> >
>> >
>> > --
>> >
>> > Piotr Zarzycki
>> >
>>
>>
>> --
>>
>> Piotr Zarzycki
>>
>
>
> --
> Carlos Rovira
> Apache Member & Apache Royale PMC
> *Apache Software Foundation*
> http://about.me/carlosrovira
>
>

--
Carlos Rovira
Apache Member & Apache Royale PMC
*Apache Software Foundation*
http://about.me/carlosrovira

Reply via email to