Well I spent more time. Besides the XML issues which are pretty much resolved, I ran into:
1. I have a setter in a class which was removed by the goog dead code removal. I worked around it by turning the setter into a method. I’ll see if I can come up with a minimal test case on that. 2. I have a library which has a LOT of dynamic pieces. I spent a LONG time trying to assign types to places where I was getting runtime errors. I now got to the point where there’s no more runtime errors, but it’s still not working and I’m pretty sure it’s because I missed some typing. Is there any way to keep public accessors on one library or specific classes? I’d like to compile my app with: "-js-dynamic-access-unknown-members=true", "-export-public-symbols=false", "-prevent-rename-protected-symbols=false", "-prevent-rename-public-symbols=false", "-prevent-rename-internal-symbols=false" but be able to exclude a list of classes from that. > On Dec 1, 2021, at 7:47 PM, Harbs <harbs.li...@gmail.com> wrote: > > I’m pretty sure the issue is related to events not being properly handled. > Although blinding might be worth looking into. > > I’ll look into it some more when I have more time. > > Thanks! > >> On Dec 1, 2021, at 7:14 PM, Josh Tynjala <joshtynj...@bowlerhat.dev >> <mailto:joshtynj...@bowlerhat.dev>> wrote: >> >>> It *almost* works. I found and fixed two cases of bracket access which >> broke things. Now I’m getting no errors, but it’s still not quite working. >> I’m guessing it’s something simple that I need to fix. >> >> Have you tried a smaller set of prevent-rename options? That might help you >> narrow things down, if things start working better. I'd try allowing public >> variables, and maybe public accessors, to be renamed first, and see if that >> works. Those types of symbols are most likely to be getting accessed >> dynamically somehow. However, I don't really have much in the way of tips >> to narrow it down from there. ConstantBinding would be one thing to look >> out for, which I mentioned in my summary. >
