e27215df5afd2ac93656f9708490682ec58691d6 in asjs repo works around the problem
by renaming BindingManager.
This works around the following snippet from MXMLBindingDirectiveHelper
if
(host.getProject().resolveQNameToDefinition(host.getProject().getBindingManagerClass())
!= null)
{
makeSpecialMemberVariablesForBinding();
isFlexSDK = true;
}
Where host.getProject().getBindingManagerClass() is mx.binding.BindingManager.
This was added by @Alex Harui<mailto:aha...@adobe.com>, in
09b76c2f6ec052445c217b5324662996c472d34b
Later, @Alina Kazi<mailto:alinakazi1...@gmail.com> added
mx.binding.BindingManager to the emulation layer. I don’t know if it’s actually
used anywhere but it made the compiler raise the isFlexSDK flag.
Alex, Alina, if either of you is unhappy with
e27215df5afd2ac93656f9708490682ec58691d6 please let me know so we can discuss.
For now, mxtests are passing again.
Thanks.
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Thursday, January 5, 2023 9:07 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: MXtests Are Failing
I got a little further with this.
setupBindings in implemented in Flex SDK, but not in Royale. The Royale swf
compiler thinks that MXRoyale is part of the FlexSDK and modifies MXML
constructors to call setupBindings, which does not exist, hence the error.
This confusion does not occur when building the swf version of Basic, which
also contains some MXML.
The relevant code is in
org.apache.royale.compiler.internal.codegen.databinding.MXMLDirectiveHelper.getConstructorCode().
There is an isFlexSDK flag there which enables the aforementioned constructor
modification. I do not know under which conditions this flag should be raised.
Is it for compiling Flex code (e.g. for an API report), or is it supposed to be
raised for MXRoyale code as well?
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Thursday, December 22, 2022 9:26 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: MXtests Are Failing
You can see it in CI build [1], and locally by running ant mxtests in
royale-asjs root folder.
Line 43 of the flash log [2] shows a stack trace with the following error:
Error #1069: Property http://www.adobe.com/2006/flex/mx/internal::setupBindings
not found on mx.controls.beads.TitleBarView and there is no default value
I suspect it has something to so with the fact that TileBarView is mxml but I
have not been able to trace the error to the compiler further than that the
exception is being thrown by
BindingCodeGenUtils. makeParameterFunction()
Any ideas?
[1] royale-asjs_MXTests #2 Console [Jenkins]
(azure.com)<http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/royale-asjs_MXTests/2/console>
[2] Apache Paste Bucket<https://paste.apache.org/3ehj2>
