I'll answer myself 😝 ... No, we can't modify the original files, which is
normal. Instead, what we can do is "exclude" the files that we know comply with
ASF policies. To do this, we add the following to the pom.xml:
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<version>0.13</version>
<configuration>
<excludesFile>${project.basedir}/rat-excludes.txt</excludesFile>
</configuration>
</plugin>
We create the "rat-excludes.txt" file with the exclusions. In the case of the
TDJ:
src/main/assembly/css/highlight.js/9.12.0/styles/LICENSE-highlightjs.txt
src/main/assembly/css/highlight.js/9.12.0/styles/atom-one-dark.min.css
src/main/assembly/scripts/highlight.js/9.12.0/highlight.min.js
src/main/assembly/scripts/highlight.js/9.12.0/LICENSE-highlightjs.txt
src/main/resources/assets/fonts/lato/LICENSE-Lato.txt
.vscode/launch.json
.vscode/tasks.json
asconfig.json
rat-excludes.txt
Now the compilation is correct.
Hiedra
-----Mensaje original-----
De: Maria Jose Esteve <mjest...@iest.com>
Enviado el: miércoles, 12 de marzo de 2025 1:40
Para: dev@royale.apache.org
Asunto: RE: Add files in the SDK - rat problems - Unapproved licenses
"The Apache RAT scans the source code of a project to verify compliance with
the Apache Software Foundation (ASF) licensing policies. Its main goal is to
ensure that all files have the correct licenses and headers before an official
release."
Could it be that the license headers are not recognized because they are not
Apache's?
If this were the case, we should modify the .js and .css files and change their
license text to the Apache license text. Would this be correct?
Hiedra
-----Mensaje original-----
De: Maria Jose Esteve <mjest...@iest.com> Enviado el: martes, 11 de marzo de
2025 23:20
Para: dev@royale.apache.org
Asunto: RE: Add files in the SDK - rat problems - Unapproved licenses
Ok,
I've updated "README.md" and added "LICENSE" to reflect the third-party license
information that was missing ("SIL OFL-1.1" for Lato, "BSD-3-Clause" for
Highlight.js).
I believe these changes ensure compliance with Apache ASF policies regarding
third-party dependencies (Categories A and B).
I've never done this before, if someone could look at it that would be great.
I'm still looking into how to license the files so that they are not rejected
by the build.
Thx.
Mª José Esteve García
Dpto. I+D
mjest...@iest.com
-----Mensaje original-----
De: Maria Jose Esteve <mjest...@iest.com> Enviado el: martes, 11 de marzo de
2025 20:22
Para: dev@royale.apache.org
Asunto: RE: Add files in the SDK - rat problems - Unapproved licenses
In the highlightjs files I "think" they already have it:
- I added it to the "atom-one-dark.min.css" file [1] (maybe it's not right like
that)
- and I didn't modify the .min.js because it already had a reference to the
license [2]. I can modify the file and add the license text, just like I did
with the css, but it didn't work in the css ☹
Am I missing something?
I'll investigate the B license. Thanks Josh.
[1]
https://github.com/apache/royale-asjs/blob/examples/TDJ_localresources/examples/jewel/TourDeJewel/src/main/resources/assets/css/highlight.js/9.12.0/styles/atom-one-dark.min.css
[2]
https://github.com/apache/royale-asjs/blob/examples/TDJ_localresources/examples/jewel/TourDeJewel/src/main/assembly/scripts/highlight.js/9.12.0/highlight.min.jsexamples/jewel/TourDeJewel/src/main/assembly/scripts/highlight.js/9.12.0/highlight.min.js
Hiedra
-----Mensaje original-----
De: Josh Tynjala <joshtynj...@bowlerhat.dev> Enviado el: martes, 11 de marzo de
2025 20:08
Para: dev@royale.apache.org
Asunto: Re: Add files in the SDK - rat problems - Unapproved licenses
As I understand it, rat checks for license comment headers in every text file.
I don't think it will accept a separate license file in the same directory. I
think that you need to manually insert appropriate headers into these new
files, even if the headers did not exist in the original versions.
For example, highlight.min.js and atom-one-dark.min.css are from the
highlight.js library, and their license is here:
https://github.com/highlightjs/highlight.js/blob/main/LICENSE
You'll need to modify those files to add a header for that license.
I see that Lato uses the SIL Open Font License, which is considered a Category
B license by the ASF. There are certain special rules we must follow when
including something with a Category B license.
https://www.apache.org/legal/resolved.html#category-b
--
Josh Tynjala
Bowler Hat LLC
https://bowlerhat.dev/
On Tue, Mar 11, 2025 at 11:37 AM Maria Jose Esteve <mjest...@iest.com>
wrote:
> I need your help.
>
> I am configuring the resources locally in TDJ due to the change in
> security policies of the Apache servers [apache/royale-asjs#1252<
> https://github.com/apache/royale-asjs/issues/1252#issuecomment-2698298
> 577
> >]
> In this second step of the update, among others, it is required to
> change from "https://fonts.googleapis.com/css?family=Lato:400,700"; to
> host the .ttf's and declare the @font-face in a new css file.
>
> I have downloaded the font package from the Google repo and the
> license file and I have also created the Lato.css file, where I have
> configured @font-face. The project compiles well, and works well
> locally BUT when the compilation finishes it shows me license errors for the
> files:
>
> src/main/assembly/scripts/highlight.js/9.12.0/highlight.min.js
>
> src/main/resources/assets/css/highlight.js/9.12.0/styles/atom-one-dark.min.css
> src/main/resources/assets/css/Lato400_700.css
> src/main/resources/assets/fonts/lato/OFL.txt (It is the license
> file. If I rename it to LICENSE the problem continues.)
>
> The problem is that I don't know how to include the license for these
> files to be able to include them in the SDK.
> I have downloaded the license files, I have tried adding the license
> text to the beginning of each of the files that generate problems, I
> have tried excluding them in the ApproveRoyale.xml file but nothing works...
> How should I do it?
>
> This problem will also occur when we must change the FontAwesome and
> Materials references in "Icons", so I would need to know how to proceed.
>
> Thx
>
> Hiedra
>
>
