[
https://issues.apache.org/jira/browse/SAMOA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651471#comment-14651471
]
ASF GitHub Bot commented on SAMOA-29:
-------------------------------------
GitHub user jayadeepj opened a pull request:
https://github.com/apache/incubator-samoa/pull/34
SAMOA-29: Remove hardcoded value for the duration of Storm local topology
execution
This fix is for SAMOA-29. Instead of the hard-coded value, the
PropertiesConfiguration class of Apache commons-configuration is used to
dynamically read samoa.storm.local.mode.execution.duration from config file.
Other properties excluding local topology execution is left as such. A new
method is added in StormSamoaUtils which can be reused to fetch other
properties.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jayadeepj/incubator-samoa master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-samoa/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit edde7c1ce33a8540abdf985ad0b75ea42c6e8f22
Author: jayadeepj <[email protected]>
Date: 2015-07-31T04:38:14Z
SAMOA-29: Fix storm local execution mode duration
----
> Remove hardcoded value for the duration of Storm local topology execution
> -------------------------------------------------------------------------
>
> Key: SAMOA-29
> URL: https://issues.apache.org/jira/browse/SAMOA-29
> Project: SAMOA
> Issue Type: Bug
> Components: SAMOA-Storm
> Reporter: Gianmarco De Francisci Morales
>
> From GitHub:
> In Storm local mode, the topology always executes for at most 10 minutes.
> Refer to com.yahoo.labs.samoa.LocalStormDoTask line 72.
> Possible solutions:
> 1) Add a new option to determine local topology execution duration in
> bin\samoa-storm.properties, use bin\samoa to parse the new option and pass to
> LocalStormDoTask as program argument.
> 2) Add the same new option as solution 1, use commons-configuration package
> to parse bin\samoa-storm.properties.
> For the second solution, we modify LocalStormDoTask to read the
> samoa-storm.properties using PropertiesConfiguration class of Apache
> commons-configuration. It will eliminate bash-code parsing in bin/samoa for
> all options except for $MODE_ARG.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
