[
https://issues.apache.org/jira/browse/SAMOA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661946#comment-14661946
]
ASF GitHub Bot commented on SAMOA-29:
-------------------------------------
Github user jayadeepj commented on the pull request:
https://github.com/apache/incubator-samoa/pull/34#issuecomment-128720359
Hi @gdfm, yes you are right. I had made a compile time addition of the
property file to the jar in pom.xml. I did that to avoid a code like this
_config = new
PropertiesConfiguration(/some/hardcoded/path/to/bin/samoa-storm.properties)_
Also We may not be able to simply omit samoa-storm.properties from the jar,
as the samoa-storm.properties need to be in classpath for the
PropertiesConfiguration to pick it up. The second alternative that is to
update the bin/samoa script to add 'bin' directory to the CLASSPATH something
like
_CLASSPATH="$CLASSPATH:$STORM_HOME/lib/*:$BASE_DIR/:$DEPLOYABLE"
java -cp $CLASSPATH org.apache.samoa.LocalStormDoTask $COMPLETE_ARG
$NUM_WORKER_
In this second alternative, we may need to update pom.xml to include a
testResources as well for the storm junits. Let me know your thoughts. Will be
happy to implement.
> Remove hardcoded value for the duration of Storm local topology execution
> -------------------------------------------------------------------------
>
> Key: SAMOA-29
> URL: https://issues.apache.org/jira/browse/SAMOA-29
> Project: SAMOA
> Issue Type: Bug
> Components: SAMOA-Storm
> Reporter: Gianmarco De Francisci Morales
>
> From GitHub:
> In Storm local mode, the topology always executes for at most 10 minutes.
> Refer to com.yahoo.labs.samoa.LocalStormDoTask line 72.
> Possible solutions:
> 1) Add a new option to determine local topology execution duration in
> bin\samoa-storm.properties, use bin\samoa to parse the new option and pass to
> LocalStormDoTask as program argument.
> 2) Add the same new option as solution 1, use commons-configuration package
> to parse bin\samoa-storm.properties.
> For the second solution, we modify LocalStormDoTask to read the
> samoa-storm.properties using PropertiesConfiguration class of Apache
> commons-configuration. It will eliminate bash-code parsing in bin/samoa for
> all options except for $MODE_ARG.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
