Github user gdfm commented on a diff in the pull request:
https://github.com/apache/incubator-samoa/pull/48#discussion_r55137139
--- Diff:
samoa-instances/src/main/java/org/apache/samoa/instances/AvroLoader.java ---
@@ -254,12 +257,30 @@ protected InstanceInformation getHeader() {
List<String> attributeLabels = attributeSchema.getEnumSymbols();
attributes.add(new Attribute(field.name(), attributeLabels));
}
- else
+ else if (isNumeric(field))
--- End diff --
I think the idea here is that if we don't know better, we treat the
attribute as numeric.
With this change, we ignore attributes we don't know how to treat.
Is my understanding correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
