Github user gdfm commented on the pull request:
https://github.com/apache/incubator-samoa/pull/48#issuecomment-192876600
Thanks for the patch @edi-bice !
There are a few changes that go beyond the scope of the patch, and their
goal is not entirely clear to me.
For the rest, apart from some small doubts, the patch looks good.
Please have a look at my comments, and see if they make sense.
I'd like to get the patch in soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
