Github user gdfm commented on a diff in the pull request:

    https://github.com/apache/incubator-samoa/pull/61#discussion_r123518192
  
    --- Diff: 
samoa-api/src/main/java/org/apache/samoa/evaluation/BasicRegressionPerformanceEvaluator.java
 ---
    @@ -92,6 +106,22 @@ public void addResult(Instance inst, double[] 
prediction) {
         };
       }
     
    +  /**
    +   * This method is used to retrieve predictions
    +   * 
    +   * @return String This returns an array of predictions and votes objects.
    +   */
    +  @Override
    +  public Vote[] getPredictionVotes() {
    +    double trueValue = this.lastSeenInstance.classValue();
    +    return new Vote[] {
    +        new Vote("instance number",
    +            this.instanceIdentifier),
    +        new Vote("true value", trueValue, 10),
    --- End diff --
    
    Can you define a constant with an understandable name for the value 10?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to