Github user mgrzenda commented on a diff in the pull request:
https://github.com/apache/incubator-samoa/pull/61#discussion_r125297279
--- Diff:
samoa-api/src/main/java/org/apache/samoa/evaluation/EvaluatorProcessor.java ---
@@ -179,6 +211,28 @@ private void addMeasurement() {
}
}
+ /**
+ * This method is used to create one line of a text file containing
predictions and votes (for classification only).
+ * In case, this is the first line a header line is also added
+ */
+ private void addVote() {
+ List<Vote> votes = new Vector<>();
+ Collections.addAll(votes, evaluator.getPredictionVotes());
+ Vote[] finalVotes = votes.toArray(new Vote[votes.size()]);
+ learningCurve.setVote(finalVotes);
+ logger.debug("evaluator id = {}", this.id);
+
--- End diff --
The important role of Vote-related methods in LearningCurve is to ensure
that Vote objects are placed every time in the same sequence (which is done by
setVote()). This is important to ensure that individual columns are printed in
every line of prediction file in the same sequence. Hence, we suggest to keep
the current solution, which uses learningCurve. The addVoteName() method is
consistent with addMeasurementName() used for the same reason for measurements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
