----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34011/#review83210 -----------------------------------------------------------
Thanks for reviewing Chinmay. I will update the diff. Please read my response to your comment about the Snapshot getMax() method and lmk what you think. samza-core/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java <https://reviews.apache.org/r/34011/#comment134110> Yes. Tt would occasionally be off by one causing an index out of bounds. Use it and file a bug to take a look at that? samza-core/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java <https://reviews.apache.org/r/34011/#comment134111> I'm implenting an interface so I can't throw an exception. I will implement it. - Luis De Pombo On May 9, 2015, 6:31 a.m., Luis De Pombo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34011/ > ----------------------------------------------------------- > > (Updated May 9, 2015, 6:31 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Add support for a Graphite Metrics Reporter > > > Diffs > ----- > > build.gradle ac80a8664180e556ec83e229e04e3d8c56b70506 > checkstyle/import-control.xml 5f8e103a2e43f96518b20de1c7cbd84e0af24842 > gradle/dependency-versions.gradle ee6dfc411b7ab90b187df79f109884127953862e > > samza-core/src/main/java/org/apache/samza/metrics/reporter/GraphiteCounter.java > PRE-CREATION > > samza-core/src/main/java/org/apache/samza/metrics/reporter/GraphiteGauge.java > PRE-CREATION > > samza-core/src/main/java/org/apache/samza/metrics/reporter/GraphiteReporterFactory.java > PRE-CREATION > > samza-core/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java > PRE-CREATION > > samza-core/src/main/java/org/apache/samza/metrics/reporter/GraphiteTimer.java > PRE-CREATION > > samza-core/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java > PRE-CREATION > > samza-core/src/test/java/org/apache/samza/metrics/reporter/GraphiteCounterTest.java > PRE-CREATION > > samza-core/src/test/java/org/apache/samza/metrics/reporter/GraphiteGaugeTest.java > PRE-CREATION > > samza-core/src/test/java/org/apache/samza/metrics/reporter/GraphiteSnapshotTest.java > PRE-CREATION > > samza-core/src/test/java/org/apache/samza/metrics/reporter/GraphiteTimerTest.java > PRE-CREATION > > samza-core/src/test/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporterTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/34011/diff/ > > > Testing > ------- > > > Thanks, > > Luis De Pombo > >
