----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34011/#review84718 -----------------------------------------------------------
docs/learn/documentation/versioned/container/metrics.md <https://reviews.apache.org/r/34011/#comment136054> Lets keep that original description. Maybe just remove the Graphite part towards the end docs/learn/documentation/versioned/container/metrics.md <https://reviews.apache.org/r/34011/#comment136059> Can you use something other than localhost ? like graphitehost.example.com docs/learn/documentation/versioned/container/metrics.md <https://reviews.apache.org/r/34011/#comment136058> Just curious - do people do this usually ? Send to 2 different graphite hosts ? Or do they go through some kind of proxy host ? samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java <https://reviews.apache.org/r/34011/#comment136060> nit: use final Timer timer ? samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java <https://reviews.apache.org/r/34011/#comment136061> nit: Use final for snapshot ? - Chinmay Soman On May 21, 2015, 7:54 a.m., Luis De Pombo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34011/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 7:54 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Add support for a Graphite Metrics Reporter > > > Diffs > ----- > > build.gradle a5f54106a822dc91ff82270df27217a8765a0d80 > checkstyle/import-control.xml 5f8e103a2e43f96518b20de1c7cbd84e0af24842 > docs/learn/documentation/versioned/container/metrics.md > 11a62f9c8bb8b7a448714a81c8ab08c6a0375562 > docs/learn/documentation/versioned/jobs/configuration-table.html > 405e2cea4fd1d037cc26b3537f6bb406eded202b > gradle/dependency-versions.gradle d79213f6237d8026d2c83a415d1a8fb2e2976d40 > > samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteCounter.java > PRE-CREATION > > samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteGauge.java > PRE-CREATION > > samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteReporterFactory.java > PRE-CREATION > > samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java > PRE-CREATION > > samza-graphite/src/main/java/org/apache/samza/metrics/reporter/GraphiteTimer.java > PRE-CREATION > > samza-graphite/src/main/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporter.java > PRE-CREATION > > samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteCounterTest.java > PRE-CREATION > > samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteGaugeTest.java > PRE-CREATION > > samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteSnapshotTest.java > PRE-CREATION > > samza-graphite/src/test/java/org/apache/samza/metrics/reporter/GraphiteTimerTest.java > PRE-CREATION > > samza-graphite/src/test/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporterTest.java > PRE-CREATION > settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb > > Diff: https://reviews.apache.org/r/34011/diff/ > > > Testing > ------- > > > Thanks, > > Luis De Pombo > >
