----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50318/ -----------------------------------------------------------
Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure). Repository: samza Description ------- After the thread-safe kafka producer change, all producer need to register the source before publishing to it. The registering of KafkaCheckpointMigration happens in the wrong place. Move it after the producer is created. Also find an extra logging introduced by the change. Remove it during this fix. Diffs ----- samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 7245902c69c751a4e8853745de46adf5553d45f5 samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala 5d2641ab1e54d49f7b983bc526762cfb50f2911b Diff: https://reviews.apache.org/r/50318/diff/ Testing ------- Tested by locally deployed jobs. Passed gradle tests. Thanks, Xinyu Liu
