----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50318/#review143446 -----------------------------------------------------------
Fix it, then Ship it! One question. Otherwise, looks good! +1 samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala <https://reviews.apache.org/r/50318/#comment209242> This info looks pretty useful. Any particular reason you are removing this ? - Navina Ramesh On July 25, 2016, 9:29 p.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50318/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 9:29 p.m.) > > > Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure). > > > Repository: samza > > > Description > ------- > > KafkaCheckpointMigration is not needed anymore for ver 11. remove the code. > > Also find an extra logging introduced by the change. Remove it during this > fix. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala > 7245902c69c751a4e8853745de46adf5553d45f5 > samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala > a3613ff601131ec8643e407dd89a5b496aa686ea > > samza-core/src/main/scala/org/apache/samza/migration/JobRunnerMigration.scala > f38b87ac4a5d3f62e419e0c866e15b5a7ddad26d > samza-core/src/test/scala/org/apache/samza/job/TestJobRunner.scala > e97656aeac270bddcd16248b37312c146d0a7d1b > > samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala > 5d2641ab1e54d49f7b983bc526762cfb50f2911b > > samza-kafka/src/test/scala/org/apache/samza/migration/TestKafkaCheckpointMigration.scala > 504fc89133702952dcaacb01d06449134b6d8921 > > Diff: https://reviews.apache.org/r/50318/diff/ > > > Testing > ------- > > Tested by locally deployed jobs. > > Passed gradle tests. > > > Thanks, > > Xinyu Liu > >
