mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262815895
########## File path: samza-core/src/main/java/org/apache/samza/coordinator/CoordinationUtils.java ########## @@ -39,6 +42,12 @@ DistributedLockWithState getLockWithState(String lockId); + DistributedReadWriteLock getReadWriteLock(); Review comment: Why does this not take a lock id? Are we imposing that you can only have one read write lock per coordination utils instance? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services