mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r263825107
########## File path: samza-core/src/main/java/org/apache/samza/coordinator/CoordinationUtils.java ########## @@ -39,6 +42,10 @@ DistributedLockWithState getLockWithState(String lockId); + DistributedReadWriteLock getReadWriteLock(String lockId); + + DistributedDataAccess getDataAccess(DistributedDataStateListener listener); Review comment: Why do you need the listener to get a handle on data access class? It forces you to have one listener across the lifecycle of `DistributedDataAccess`. Don't you need fine grained listeners on the key basis? I was under the assumption `DistributedDataAccess` will have a method called `addListener(key, listener)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
