mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r263843961
########## File path: samza-core/src/main/java/org/apache/samza/coordinator/DistributedDataAccess.java ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.coordinator; + +/** + * Concurrent writes are not allowed but concurrent reads are. Review comment: I suppose you are describing the scenario within the framework that leverages this abstraction. I would not tie the document to that and rather define broader guarantees and expectation of API. Things like * Is it thread safe? * Does the framework expect synchronization from the implementers? In our current use case, we use external synchronization to write data into the store. * Also, there is no guarantee that the data is available fo subsequent reads; at least w/ the ZK implementation unless you plan to sync on every read. I'd try to split them to individual expectations on for write and read and add them to method level java docs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
