cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade
to Kafka 2.0
URL: https://github.com/apache/samza/pull/951#discussion_r267059448
##########
File path:
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java
##########
@@ -717,4 +744,21 @@ private OffsetsMaps(Map<SystemStreamPartition, String>
oldestOffsets,
return upcomingOffsets;
}
}
+
+ /**
+ * A helper class for represent changelog related information.
+ */
+ private static class ChangelogInfo {
+ int replicationFactor;
Review comment:
Could you make this an immutable object with getters?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
