cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade
to Kafka 2.0
URL: https://github.com/apache/samza/pull/951#discussion_r267088346
##########
File path:
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala
##########
@@ -93,48 +95,45 @@ object TestKafkaSystemAdmin extends KafkaServerTestHarness
{
}
def createTopic(topicName: String, partitionCount: Int) {
- AdminUtils.createTopic(
- zkUtils,
- topicName,
- partitionCount,
- REPLICATION_FACTOR)
+ createTopic(topicName, partitionCount, REPLICATION_FACTOR)
}
def validateTopic(topic: String, expectedPartitionCount: Int) {
var done = false
var retries = 0
- val maxRetries = 100
- while (!done && retries < maxRetries) {
+ while (!done && retries < 100) {
try {
- val topicMetadataMap = TopicMetadataCache.getTopicMetadata(Set(topic),
SYSTEM, metadataStore.getTopicInfo)
- val topicMetadata = topicMetadataMap(topic)
+ if (!zkClient.topicExists(topic)) {
Review comment:
Looks like indentation might be off?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
