-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17869/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-59
https://issues.apache.org/jira/browse/SAMZA-59
Repository: samza
Description
-------
I have added a boolean flag (serdeErrorDrop) to SystemConsumers.scala
To allow configuration of the behavior when we have an incoming message that
fails on deserialization.
I moved the message deserialization up before updateFetchMap().
I tried to setup the configuration, but it was not working. I am getting a
compiler error, and I could not find where the other configurations were setup.
NOTE : I tried to make my change consistent with the rest of the code, but I am
not too familiar with scala.
Diffs
-----
samza-core/src/main/scala/org/apache/samza/config/SystemConsumersConfig.scala
PRE-CREATION
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
13421d2
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala
cdba7fe
Diff: https://reviews.apache.org/r/17869/diff/
Testing
-------
I tested both setting dropOnSerdeError to true and to false, and they both
seemed to work.
But the configuration was not working, and I could not figure out how to get it
working.
Thanks,
Daniel Antonetti
