> On Feb. 10, 2014, 10:11 p.m., Chris Riccomini wrote: > > 1. Clean up misc white space tabs (highlighted in red) in RB. > > 2. Add a test. > > 3. Update docs to describe new configuration > > (docs/learn/documentation/0.7.0/jobs/configuration-table.html) > > Daniel Antonetti wrote: > 1/3 Done, I still need to look at the tests.
I am done with 1 and 3. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17869/#review34108 ----------------------------------------------------------- On Feb. 17, 2014, 6:48 a.m., Daniel Antonetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17869/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2014, 6:48 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-59 > https://issues.apache.org/jira/browse/SAMZA-59 > > > Repository: samza > > > Description > ------- > > I have added a boolean flag (serdeErrorDrop) to SystemConsumers.scala, Which > will allow a configuration to drop bad incoming messages. > > > I moved the message deserialization up before updateFetchMap(). > > > I tried to setup the configuration, but it was not working. I am getting a > compiler error, and I could not find where the other configurations were > setup. > > > NOTE : I tried to make my change consistent with the rest of the code, but I > am not too familiar with scala. > > > Diffs > ----- > > docs/learn/documentation/0.7.0/jobs/configuration-table.html 8b42b3a > samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 3510f1f > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 13421d2 > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala > cdba7fe > > samza-core/src/main/scala/org/apache/samza/system/SystemConsumersMetrics.scala > d632314 > > Diff: https://reviews.apache.org/r/17869/diff/ > > > Testing > ------- > > I tested both setting dropOnSerdeError to true and to false, and they both > seemed to work. > But the configuration was not working, and I could not figure out how to get > it working. > > > Thanks, > > Daniel Antonetti > >
