> On March 21, 2014, 4:28 a.m., Chris Riccomini wrote: > > samza-shell/src/main/bash/checkpoint-tool.sh, line 19 > > <https://reviews.apache.org/r/19481/diff/2/?file=530758#file530758line19> > > > > No need for log4j setting here. run-class.sh will auto-add it if it > > exists in the lib directory of a package. If it doesn't, it's up to the > > user to add an appropriate slf4j module (e.g. slf4j-simple, slf4j-avsl, > > etc), and configure it with SAMZA_OPTS, accordingly. > > Martin Kleppmann wrote: > At the moment, in hello-samza, log4j is configured to send all logs to a > file (which by default is called > deploy/samza/undefined-samza-container-name.log). If the tool isn't working > for some reason, that is not where I would expect to have to look for further > information. Since utilities like checkpoint-tool are meant for interactive > use, I'm keen for them to write their logs to stdout or stderr. > > Thus I think it would be best to have a different logging config for > command-line utilities than for containers. How do you think we should do > that? Perhaps have two different log4j configs, and each script that calls > run-class.sh should indicate whether it's interactive or daemon?
I have opened https://issues.apache.org/jira/browse/SAMZA-215 to track this, as it's really a separate concern. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19481/#review38050 ----------------------------------------------------------- On March 21, 2014, 3:14 p.m., Martin Kleppmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19481/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 3:14 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Make CheckpointTool non-Kafka-specific; move CommandLine to util; move Gradle > task to kafka-shell > > > SAMZA-180: Command-line tool for manipulating checkpoints > > > Diffs > ----- > > build.gradle 8e369b83b7c4a658e1a3660efc92a24efadc9fc1 > samza-core/src/main/resources/samza-cmdline-log4j.properties PRE-CREATION > samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala > f3a75afa96a8dc64c98f37fdb88c63075ac2374b > samza-core/src/main/scala/org/apache/samza/util/CommandLine.scala > PRE-CREATION > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala > 27b38b25dc6c34f3ef76d400370d1c857834e6a2 > samza-shell/src/main/bash/checkpoint-tool.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/19481/diff/ > > > Testing > ------- > > > Thanks, > > Martin Kleppmann > >
