----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19481/#review39281 -----------------------------------------------------------
Ship it! +1 Looks good! Regarding docs, I think just updating the README.md to describe how to use the tasks is probably good enough for now. As you said, when we get a full release, we can document how to run the checkpoint-tool.sh separately, but for now, all the build/gradle related stuff is just in README.md/RELEASE.md. - Chris Riccomini On April 2, 2014, 4:21 p.m., Martin Kleppmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19481/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 4:21 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Rationalize logging and added tests, as per review > > > Make CheckpointTool non-Kafka-specific; move CommandLine to util; move Gradle > task to kafka-shell > > > SAMZA-180: Command-line tool for manipulating checkpoints > > > Diffs > ----- > > build.gradle 8e369b83b7c4a658e1a3660efc92a24efadc9fc1 > gradle/dependency-versions.gradle 612670dded2c2d290f1bc36ece1f3d53ffa4e971 > samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala > f3a75afa96a8dc64c98f37fdb88c63075ac2374b > samza-core/src/main/scala/org/apache/samza/util/CommandLine.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/checkpoint/TestCheckpointTool.scala > PRE-CREATION > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala > 27b38b25dc6c34f3ef76d400370d1c857834e6a2 > samza-shell/src/main/bash/checkpoint-tool.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/19481/diff/ > > > Testing > ------- > > > Thanks, > > Martin Kleppmann > >
