----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20542/#review41025 -----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala <https://reviews.apache.org/r/20542/#comment74381> Could you include e (the throwable) in the KafkaCheckpointException for all three of these, as well? - Chris Riccomini On April 21, 2014, 11:54 p.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20542/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 11:54 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Fail the samza job when unrecoverable Kafka exception occurs. > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala > fed6eee > > samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala > f1a8f8a > > Diff: https://reviews.apache.org/r/20542/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > >
