----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20542/ -----------------------------------------------------------
(Updated April 22, 2014, 7:10 p.m.) Review request for samza. Changes ------- 1. Added throwable e to the KafkaCheckpointException 2. Changed checkpointTopic and clientId in getKafkaCheckpointManagerWithInvalidSerde of TestKafkaCheckpintException to make them different from those in getKafkaCheckpointManager. Otherwise, it would fail the test if testUnrecovableKafkaErrorShouldThrowKafkaCheckpointManagerException is run before testCheckpointShouldBeNullIfcheckpointTopicDoesNotExistShouldBeCreatedOnWriteAndShouldBeReadableAfterWrite. 3. Fixed the typo of getKafkaCheckpointManagerWithInvalideSerde to getKafkaCheckpointManagerWithInvalidSerde (removed the e after Invalid) Repository: samza Description ------- Fail the samza job when unrecoverable Kafka exception occurs. Diffs (updated) ----- samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala fed6eee samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala f1a8f8a Diff: https://reviews.apache.org/r/20542/diff/ Testing ------- Thanks, Yan Fang
