----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20811/ -----------------------------------------------------------
Review request for samza. Repository: samza Description ------- add javadocs, and reset deletion counter in compact make delete threshold configurable. add a performance test (takes 25s to run). make compaction lazy on read-side so we can take advantage of cached writes trigger compactions periodically to remove deleted keys from levels Diffs ----- samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineFactory.scala 81fe86165019f72a15be1ac9cfcfff0598b4b92b samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala 8602a328673e6fa7d435366abcd9a96a99d9cd88 samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 85ba11a3362ad7cf4f84fbcbd944cd790e572cbe Diff: https://reviews.apache.org/r/20811/diff/ Testing ------- Thanks, Chris Riccomini
