> On April 29, 2014, 5:52 p.m., Jakob Homan wrote: > > samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala, > > line 289 > > <https://reviews.apache.org/r/20811/diff/1/?file=569851#file569851line289> > > > > This really isn't a test, as it's not possible for it to fail. It's > > more of a benchmark. Perhaps move it to a separate main-ed class that can > > be run from the command line for manual checking? Either that or add some > > you-shall-not-pass value that will fail the test if performance dips too > > low, but that's fraught with per-machine variation.
+1. I would love there to be a separate performance test suite which we can run regularly, but it needs to be separate from the unit/functional/integration test suite. Lucene does this very well: http://people.apache.org/~mikemccand/lucenebench/ -- they have created a standardised set of performance tests, have run them every day for over 3 years, and graphed the results. It's awesome to see performance work quantified like that. You make what you measure :) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20811/#review41731 ----------------------------------------------------------- On April 28, 2014, 10:52 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20811/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 10:52 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > add javadocs, and reset deletion counter in compact > > > make delete threshold configurable. add a performance test (takes 25s to run). > > > make compaction lazy on read-side so we can take advantage of cached writes > > > trigger compactions periodically to remove deleted keys from levels > > > Diffs > ----- > > > samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineFactory.scala > 81fe86165019f72a15be1ac9cfcfff0598b4b92b > > samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala > 8602a328673e6fa7d435366abcd9a96a99d9cd88 > > samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala > 85ba11a3362ad7cf4f84fbcbd944cd790e572cbe > > Diff: https://reviews.apache.org/r/20811/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
