----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22748/#review46256 -----------------------------------------------------------
Going through the steps in README.md does install required version of jekyll and redcarpet. Only few suggestions. Thank you. docs/README.md <https://reviews.apache.org/r/22748/#comment81570> add something like "go to docs directory"? Otherwise, it can not install. docs/README.md <https://reviews.apache.org/r/22748/#comment81571> Is "bundle exec" needed? After installed, we can directly run jekyll. docs/README.md <https://reviews.apache.org/r/22748/#comment81572> Is "bundle exec" necessary here? - Yan Fang On June 18, 2014, 6:37 p.m., Martin Kleppmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22748/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 6:37 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-297: Fix the version of Jekyll (and deps) for building docs. > > > Diffs > ----- > > docs/Gemfile PRE-CREATION > docs/Gemfile.lock PRE-CREATION > docs/README.md 0edd84e8931eea4f38be7bcc9824f78d51652292 > docs/_config.yml 9ffb45c62196932081381660792033db58e5f5ff > > Diff: https://reviews.apache.org/r/22748/diff/ > > > Testing > ------- > > > Thanks, > > Martin Kleppmann > >
