> On June 20, 2014, 5:40 a.m., Yan Fang wrote: > > docs/README.md, line 26 > > <https://reviews.apache.org/r/22748/diff/1/?file=612453#file612453line26> > > > > Is "bundle exec" needed? After installed, we can directly run jekyll. > > Martin Kleppmann wrote: > It is necessary in order to enforce the version constraint. If you just > run "jekyll", Rubygems will by default use the latest version of all > dependencies that you have installed (whether or not it matches the > constraints in the Gemfile). If you run "bundle exec jekyll", it will use the > exact versions that were fixed in Gemfile.lock, and tell you to install them > if they aren't already. > > Yan Fang wrote: > Oh, cool. Then we may also want to change the "jekyll build" in > docs/publish-site.sh to "bundle exec jekyll build".
Agree, I've updated it. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22748/#review46256 ----------------------------------------------------------- On June 24, 2014, 5:09 p.m., Martin Kleppmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22748/ > ----------------------------------------------------------- > > (Updated June 24, 2014, 5:09 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-297: Fix the version of Jekyll (and deps) for building docs. > > > Diffs > ----- > > docs/Gemfile PRE-CREATION > docs/Gemfile.lock PRE-CREATION > docs/README.md 0edd84e8931eea4f38be7bcc9824f78d51652292 > docs/_config.yml 9ffb45c62196932081381660792033db58e5f5ff > docs/_tools/publish-site.sh b20c4e7c6c390bfc3a10ae5f33acb3db458b8a03 > docs/contribute/code.md b9a3c0240fda508fbe1a9a02d656be47d3da44f0 > > Diff: https://reviews.apache.org/r/22748/diff/ > > > Testing > ------- > > > Thanks, > > Martin Kleppmann > >
