jrihtarsic commented on code in PR #271:
URL:
https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1592359981
##########
src/main/java/org/apache/xml/security/encryption/XMLCipherUtil.java:
##########
@@ -271,93 +272,42 @@ public static KeyAgreementParameters
constructAgreementParameters(String agreeme
* Construct a KeyDerivationParameter object from the given
keyDerivationMethod and keyBitLength
*
* @param keyDerivationMethod element with the key derivation method data
- * @param keyBitLength expected derived key length
+ * @param keyBitLength expected derived key length in bits
* @return KeyDerivationParameters data
- * @throws XMLSecurityException if the keyDerivationMethod is not
supported or invalid parameters are provided
+ * @throws XMLSecurityException if the invalid key derivation parameters
are provide
Review Comment:
I updated the code now to ensure that only the XMLEncryptionException can be
thrown. I made changes to the XMLCipherUtil.constructKeyDerivationParameter
method only and retained the XMLSecurityException in the interface
KeyDerivationMethod.getKDFParams; because the interface implementation may be
used for key derivation functions used for other purposes than just the
encryption in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
