fgreg commented on a change in pull request #61: SDAP-105 DOMS matchup netcdf
and csv generation
URL:
https://github.com/apache/incubator-sdap-nexus/pull/61#discussion_r243464603
##########
File path: analysis/webservice/algorithms/doms/BaseDomsHandler.py
##########
@@ -124,41 +127,63 @@ def __packValues(csv_mem_file, results):
headers = [
# Primary
- "id", "source", "lon", "lat", "time", "platform",
"sea_water_salinity_depth", "sea_water_salinity",
- "sea_water_temperature_depth", "sea_water_temperature",
"wind_speed", "wind_direction", "wind_u", "wind_v",
+ "id", "source", "lon (degrees_east)", "lat (degrees_north)",
"time", "platform",
+ "sea_surface_salinity (1e-3)", "sea_surface_temperature
(degree_C)", "wind_speed (m s-1)", "wind_direction",
+ "wind_u (m s-1)", "wind_v (m s-1)",
# Match
- "id", "source", "lon", "lat", "time", "platform",
"sea_water_salinity_depth", "sea_water_salinity",
- "sea_water_temperature_depth", "sea_water_temperature",
"wind_speed", "wind_direction", "wind_u", "wind_v"
+ "id", "source", "lon (degrees_east)", "lat (degrees_north)",
"time", "platform",
+ "depth (m)", "sea_water_salinity (1e-3)",
+ "sea_water_temperature (degree_C)", "wind_speed (m s-1)",
+ "wind_direction", "wind_u (m s-1)", "wind_v (m s-1)"
]
writer.writerow(headers)
+ #
+ # Compress multiple depth variables into one depth array
+ #
+ depthAggregate = []
Review comment:
I'm a little confused about this depth logic, can you explain? It seems like
you are picking either the SSS or SST depth if one exists. Are you sure that in
all cases depth will be the same between SSS and SST insitu measurements? Also,
is it necessary to iterate the matches twice; couldn't this if statement be
done as part of the row construction below?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
