fgreg commented on a change in pull request #61: SDAP-105 DOMS matchup netcdf
and csv generation
URL:
https://github.com/apache/incubator-sdap-nexus/pull/61#discussion_r243461345
##########
File path: analysis/webservice/algorithms/doms/BaseDomsHandler.py
##########
@@ -173,7 +198,7 @@ def __addConstants(csvfile):
{"Global Attribute": "keywords_vocabulary",
"Value": "NASA Global Change Master Directory (GCMD) Science
Keywords"},
# TODO What should the keywords be?
- {"Global Attribute": "keywords", "Value": ""},
+ {"Global Attribute": "keywords", "Value": "Salinity, Upper Ocean,
SPURS, CTD, Endeavor, Atlantic Ocean"},
Review comment:
There was some discussion around this previously and it was decided to
simply leave keywords blank because of the diverse nature of the data in the
file. What if the matchup doesn't contain any SPURS data, should the SPURS
keyword still be included? I'd still argue for leaving these blank but if a
discussion about it has happened I will defer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
